Include assert message in contribute and PR template#579
Merged
smartie2076 merged 5 commits intodevfrom Sep 30, 2020
Merged
Conversation
smartie2076
approved these changes
Sep 30, 2020
Collaborator
smartie2076
left a comment
There was a problem hiding this comment.
You need to update the changelog ;)
| fails (`assert <condition>, <string message>`). It could be very useful to understand what exactly | ||
| went wrong in the test for a developer 6 months from now. | ||
| If you are testing a function in a module, it would be nice to indicate in the docstring of this | ||
| function (under the section `Notes`) that this test exist, cf [example docstring](https://mvs-eland.readthedocs.io/en/latest/Developing.html#format-of-docstrings)! |
Collaborator
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
Haha, okay. Thought it was a typo.
Co-authored-by: smartie2076<[email protected]>
543d126 to
b19ceb1
Compare
Collaborator
Author
|
@smartie2076 you can push when the test have ran |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #540
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
For more information on how to contribute check the CONTRIBUTING.md.