Skip to content

Fix piecharts to display actual project currency#561

Merged
ursulaelmir merged 2 commits intodevfrom
fix/USD_currency_in_plots
Sep 21, 2020
Merged

Fix piecharts to display actual project currency#561
ursulaelmir merged 2 commits intodevfrom
fix/USD_currency_in_plots

Conversation

@smartie2076
Copy link
Copy Markdown
Collaborator

Fix #553

Changes proposed in this pull request:

  • Change F1.plot_piecharts_of_costs() now cites costs with currect currency and avoids decimal numbers
  • Fix Graphs of the report now use appropriate currency

The following steps were realized, as well (if applies):
❌ Use in-line comments to explain your code
❌ Write docstrings to your code
❌ For new functionalities: Explain in readthedocs
❌ Write test(s) for your new patch of code

  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

@smartie2076 smartie2076 added the enhancement New feature or request label Sep 10, 2020
@smartie2076 smartie2076 self-assigned this Sep 10, 2020
@smartie2076
Copy link
Copy Markdown
Collaborator Author

@ursulaelmir can you review? By the end of this day we can also release a new MVS version so that you can reference the release that you have been working with.

@ursulaelmir ursulaelmir merged commit 86ce30e into dev Sep 21, 2020
@ursulaelmir ursulaelmir deleted the fix/USD_currency_in_plots branch September 21, 2020 10:49
@smartie2076 smartie2076 mentioned this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Graphs of the report use "$" and not defined currency

2 participants