Skip to content

Fix C1.check_feedin_tariff()#552

Merged
smartie2076 merged 2 commits intodevfrom
fix/check_feedin_tariff
Sep 3, 2020
Merged

Fix C1.check_feedin_tariff()#552
smartie2076 merged 2 commits intodevfrom
fix/check_feedin_tariff

Conversation

@smartie2076
Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 commented Sep 3, 2020

Fix #550

Changes proposed in this pull request:

  • Now diff can also be of type int

Notes:

  • There are still some pytests missing for the function, specifically for prices/tariffs provided as a timeseries

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

@smartie2076 smartie2076 added the bug Something isn't working label Sep 3, 2020
@smartie2076 smartie2076 self-assigned this Sep 3, 2020
@smartie2076
Copy link
Copy Markdown
Collaborator Author

@ursulaelmir ready to merge after your review.

@smartie2076 smartie2076 merged commit 2cb0802 into dev Sep 3, 2020
@smartie2076 smartie2076 deleted the fix/check_feedin_tariff branch September 3, 2020 14:10
@smartie2076 smartie2076 mentioned this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] C1.check_feedin_tariff() needs to be fixed

2 participants