Conversation
To ensure feature of timeseries for scalar values
|
@smartie2076, the files that were in |
|
@ursulaelmir I have not written the tests for this jet, but two input flows for an energyConversion object may be simulated with these inputs: Feature_input_flows_as_list.zip As said, I did not test the results! I just want to update you on this. If you need any intervention from me regarding this, you should drop the issue until after you handed in your thesis. |
….com/smartie2076/mvs_eland into patch/tests_for_features # Conflicts: # CHANGELOG.md # tests/test_F0_output.py
…input/output flows
…input/output flows
|
@Bachibouzouk you could also review this one, but only if you do not go by commits :'D |
Bachibouzouk
left a comment
Bachibouzouk
left a comment
There was a problem hiding this comment.
The docstrings can be added in a subsequent PR. I would just remove the code which is commented out if it is not going to be considered here.
|
@smartie2076 - can this be merged (once the conflict with changelog has been solved of course) |
I need to change the description of the PR, but that is all. It will not fix the issue it was supposed to fix, though ;) |
….com/smartie2076/mvs_eland into patch/tests_for_features # Conflicts: # CHANGELOG.md Merge dev
….com/smartie2076/mvs_eland into patch/tests_for_features # Conflicts: # CHANGELOG.md Add assert debug messages
|
@Bachibouzouk I think it is fine to merge, the commented out benchmark tests are intentional. |
2 participants
Not addressed checkpoints are summarized in #541. For solving #541, please also look at what was done in this PR.
Changes proposed in this pull request:
test_benchmark_feature_parameters_as_timeseries: Applied toefficiencyandenergy_price.test_benchmark_feature_output_flows_as_list(applied to an energyConsumption asset)test_benchmark_feature_input_flows_as_list(applied to an energyConsumption asset)The following steps were realized, as well (if applies):
black . --exclude docs/)