Skip to content

Add system-wide KPI to evaluation#525

Merged
smartie2076 merged 39 commits intodevfrom
feature/sector_wide_kpi
Aug 28, 2020
Merged

Add system-wide KPI to evaluation#525
smartie2076 merged 39 commits intodevfrom
feature/sector_wide_kpi

Conversation

@smartie2076
Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 commented Aug 24, 2020 •
edited
Loading

Fix #516
Fix #222
Adresses #513

Changes proposed in this pull request:

  • Add system-wide KPI to automatic reporting
  • Add LCOE per energy carrier
  • Check expected values of LCOE and NPC in KPI pytest
  • Check expected value of Renewable share in pytest
  • Added a Literature.rst file for documenting publications/resources regarding the MVS

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@smartie2076 smartie2076 added the enhancement New feature or request label Aug 24, 2020
@smartie2076 smartie2076 self-assigned this Aug 24, 2020
@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented Aug 24, 2020

@Bachibouzouk while doing this I noticed that the tables of the report are not printing the whole df, but only its columns. Would it not make sense to also print the index, so that there is no manual sorting of the columns necessary?

@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented Aug 24, 2020

@ursulaelmir the total NPV and annuity are, infact, already without this PR accessible. Here, they are now printed at the end of the report (no unit).

simulation_report.pdf

smartie2076 added 3 commits August 25, 2020 11:28
Added units to system cost KPI
bce277c 
Some of these changes might be overthrown as soon as we figure out a way to display units nicer.
Update CHANGELOG.md
91cfa81
Added References.rst to readthedocs
1675ce4
Bachibouzouk
Bachibouzouk reviewed Aug 25, 2020
View reviewed changes
Bachibouzouk
Bachibouzouk reviewed Aug 25, 2020
View reviewed changes
@smartie2076 smartie2076 mentioned this pull request Aug 25, 2020
Merged
14 tasks
Base automatically changed from patch/economic_postprocessing to dev August 25, 2020 14:26
@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented Aug 25, 2020

@ursulaelmir the system-wide LCOE is now already implemented in this branch. There are no unit tests or benchmark tests for this feature yet.

smartie2076 and others added 15 commits August 25, 2020 19:21
@smartie2076 @Bachibouzouk
Apply suggestions from code review
29d061f 
Co-authored-by: Pierre Francois <[email protected]>
Formatting with black
4db78cc
Merge remote-tracking branch 'origin/feature/sector_wide_kpi' into fe…
d92648b 
…ature/sector_wide_kpi
Define RENEWABLE_SHARE = "Renewable Share"
ecb855a
Fix pytest for renewable share, transform all tests into functions
f8c6168
Add docstrings
18824c1
Update Changelog
a80d878
Update E3.add_degree_of_sector_coupling(), but not functional
74c3b1b
Formatting issues
0c7523c
Add test for two sectors: renewable share
0dcfdb8
Formatting with blacks
545581b
Introduced new constant variables
59c54f4 
TOTAL_DEMAND,
SUFFIX_ELECTRICITY_EQUIVALENT,
ATTRIBUTED_COSTS,
LCOeleq,
DEGREE_OF_SECTOR_COUPLING
Added pytest for LCOeleq
8a07b5b
Formatting with blacks
71ecd34
@smartie2076
Merge branch 'dev' into feature/sector_wide_kpi
1853389
@smartie2076 smartie2076 marked this pull request as ready for review August 27, 2020 10:06
@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented Aug 27, 2020

@ursulaelmir this is ready for review now.
@Bachibouzouk: Sorry for not doing the rebase. I am on a deadline to finish a though feature for the MVS this week, and last time the rebase got really messy.

@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented Aug 27, 2020

Currently, the ATTRIBUTED_COSTS of each energy carrier as well as the LCOeleq are stored to KPI_SCALAR_DICT. It would be better to include them in KPI_UNCOUPLED_DICT. This dict is not printed in the report yet, and appears scrambled in the excel scalars.xlsx file:

image

The KPI_UNCOUPLED_DICT should be parsed into a pd.DataFrame (or be a pd.DataFrame from the start) with rows [energy_carrier_1, energy_carrier_2].

I leave this for now, as this PR implemented the KPI calculation. Making it visually pleasing can be a different PR.

@smartie2076 smartie2076 mentioned this pull request Aug 27, 2020
Open
@smartie2076 smartie2076 merged commit 7ae1333 into dev Aug 28, 2020
@smartie2076 smartie2076 deleted the feature/sector_wide_kpi branch August 28, 2020 10:51
@Bachibouzouk Bachibouzouk mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bachibouzouk Bachibouzouk Bachibouzouk left review comments

+1 more reviewer

@ursulaelmir ursulaelmir ursulaelmir approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@smartie2076 smartie2076

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The mvs' logfile name is hardcoded instead of being stored within a variable Add basic KPI to post-processing - economic parameters

3 participants

@smartie2076 @Bachibouzouk @ursulaelmir