Disaggregate and test economic postprocessing (E2) by smartie2076 · Pull Request #520 · rl-institut/multi-vector-simulator

smartie2076 · 2020-08-19T16:09:05Z

Fix #330
Fix #240
Addresses #222

Changes proposed in this pull request:

Change faulty addition sign to multiplication for cost_upfront
Disaggregate economic evaluation for easy pytest definition
Pytest for cost_upfront
Pytest for total investment costs
Pytest for total_om_costs
Pytest for annuity
Pytest for LCOE

The following steps were realized, as well (if applies):

Use in-line comments to explain your code
Write docstrings to your code
For new functionalities: Explain in readthedocs
Write test(s) for your new patch of code
Update the CHANGELOG.md
Apply black (black . --exclude docs/)
Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

smartie2076 · 2020-08-19T16:09:44Z

@ursulaelmir you can close #519, I take over with this PR.

…atch/economic_postprocessing

This shall now be used in the beginning of the economic evaluation for all necessary parameters. It will result in a warning if a parameter is missing, indicating to the developer that the E module needs to be changed.

smartie2076 · 2020-08-20T11:10:01Z

@ursulaelmir we need to be able to calculate the replacement costs of the already installed assets, as they also may need a replacement in the duration of the project. Therefore, I (re) defined C2.replacement_costs() and C2.capex_from_investment(). I am not done integrating them, but it is a heads-up.

Todo:

Replacement costs of installed assets currently not covered - use results from C2.capex_from_investment()/ C2.replacement_costs()
Update C2 pytests
Test if "price" is used at all now, or if we can scrap that one thoughout the script

src/E2_economics.py

src/F1_plotting.py

src/constants_json_strings.py

tests/test_C2_economic_functions.py

tests/test_E2_economics.py

Co-authored-by: Pierre Francois <[email protected]>

smartie2076

Thanks PF!

src/C2_economic_functions.py

Co-authored-by: Pierre Francois <[email protected]>

smartie2076

Thanks @Bachibouzouk ! I have actually fixed your remarks in #525 only (I know, I know...), as I want to merge this quickly and the changes were not essential.

src/F1_plotting.py

src/constants_json_strings.py

tests/test_C2_economic_functions.py

tests/test_E2_economics.py

Co-authored-by: Pierre Francois <[email protected]>

smartie2076 added 2 commits August 19, 2020 18:02

Update CHANGELOG.md

e2a31b6

Calculate costs_upfront with multiplication

4ef61aa

smartie2076 added the bug Something isn't working label Aug 19, 2020

smartie2076 requested a review from ursulaelmir August 19, 2020 16:09

smartie2076 self-assigned this Aug 19, 2020

smartie2076 added 11 commits August 19, 2020 18:18

Add docstrings for E2.all_list_in_dict()

da5f07e

Merge branch 'dev' of https://github.com/smartie2076/mvs_eland into p…

87d4475

…atch/economic_postprocessing

Disaggregate and test E2.calculate_costs_upfront()

0e32cb8

New constant variable: SIMULATION_RESULTS=="simulation_results"

fb050cc

Remove excess parameters from a list

5571c46

CHANGELOG.md

447eb94

One function to calculate investment costs (total and upfront)

652c18e

Disaggregate and test E2.calculate_dispatch_expenditures()

05fd424

Define and test E2.calculate_costs_investment()

3772659

Define and test E2.calculate_operation_and_management_expenditures()

32bbcf3

Define and test E2.calculate_total_operational_expenditures()

8c64d44

smartie2076 mentioned this pull request Aug 20, 2020

[Bug] Marginal negative capacities or flows #523

Closed

smartie2076 added 11 commits August 20, 2020 12:33

Definition of C2.replacement_costs(), but not integration

91cd2a0

Rename and update constants

2e4bb8f

Redefine E2.all_list_in_dict()

a00f380

This shall now be used in the beginning of the economic evaluation for all necessary parameters. It will result in a warning if a parameter is missing, indicating to the developer that the E module needs to be changed.

Redefine E2.all_list_in_dict()

b44f011

Fix function E2.calculate_operation_and_management_expenditures()

7b7fcf9

Fix tests

076adc8

define and test E2.calculate_total_asset_costs_over_lifetime()

e2fb136

Delete E2.add_costs_and_total

7e838d3

Redefine C2.capex_from_investment() with C2.replacement_costs()

71111ba

Integrate new replacement costs

c720002

Refactoring

9d25fbb