Skip to content

Fix costs_upfront calculation#519

Closed
ursulaelmir wants to merge 2 commits intodevfrom
Fix_E2_economics
Closed

Fix costs_upfront calculation#519
ursulaelmir wants to merge 2 commits intodevfrom
Fix_E2_economics

Conversation

@ursulaelmir
Copy link
Copy Markdown
Collaborator

Changes proposed in this pull request:

  • Change addition sign to multiplication

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@ursulaelmir ursulaelmir self-assigned this Aug 19, 2020
Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand if you do not want to write the tests for E2 right now, or for this one thing - as it is wrapped in a large fuction. Its just that there might be a lot of issues connected to it, as it is completely untested.
If you can fix the LCOE issue that easily, you can also take merge it like this.

You have to change the changelog, though ;)

@ursulaelmir
Copy link
Copy Markdown
Collaborator Author

@smartie2076 I think it was not the only issue or maybe I am mistaken. Can you have a look with me at the calculation of the annuity? the following is an example:

        "costs_investment_over_lifetime": {
            "value": 234123.56763754043
        },
        "costs_om_total": {
            "unit": "currency",
            "value": 13512.586121289185
        },
        "costs_total": {
            "unit": "currency",
            "value": 481759.72139637003
        },
        "costs_upfront_in_year_zero": {
            "value": 234123.56763754043

costs_total are equal to the sum of the other three. Now, to simplify the example, I will divide by the capacity (209.0389):

costs_investment_over_lifetime = 1,120
costs_om_total = 64.64 (which is 10/CRF -- 10 being o&m and crf = 0.154699)
costs_upfront_in_year_zero = 1,120
costs_total = 2,304.64 which is then multiplied by the CRF to get the annuity_total

is this the way you wanted to calculate the annuity? because I myself feel that there is some redundancy. the current PV LCOE is 0.3 !

@smartie2076
Copy link
Copy Markdown
Collaborator

costs_total are equal to the sum of the other three. Now, to simplify the example, I will divide by the capacity (209.0389):

costs_investment_over_lifetime = 1,120
costs_om_total = 64.64 (which is 10/CRF -- 10 being o&m and crf = 0.154699)
costs_upfront_in_year_zero = 1,120
costs_total = 2,304.64 which is then multiplied by the CRF to get the annuity_total

Actually, costs_upfront_in_year_zero should not be added to cost_total, as they are included in costs_investment_over_lifetime. This will then decrease the LCOE back to 0.15...

There must be another issue besides this one.

@ursulaelmir ursulaelmir reopened this Aug 19, 2020
@ursulaelmir ursulaelmir deleted the Fix_E2_economics branch August 19, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants