Conversation
smartie2076
left a comment
There was a problem hiding this comment.
I understand if you do not want to write the tests for E2 right now, or for this one thing - as it is wrapped in a large fuction. Its just that there might be a lot of issues connected to it, as it is completely untested.
If you can fix the LCOE issue that easily, you can also take merge it like this.
You have to change the changelog, though ;)
|
@smartie2076 I think it was not the only issue or maybe I am mistaken. Can you have a look with me at the calculation of the annuity? the following is an example: costs_total are equal to the sum of the other three. Now, to simplify the example, I will divide by the capacity (209.0389): costs_investment_over_lifetime = 1,120 is this the way you wanted to calculate the annuity? because I myself feel that there is some redundancy. the current PV LCOE is 0.3 ! |
Actually, There must be another issue besides this one. |
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.