Open
Conversation
This was referenced May 11, 2020
Closed
Owner
|
can you sync with master so that only relavant changes are shown, then i can merge it |
No need to support CMake on an older Ubuntu. (Although certainly resolvable.)
Author
|
The CMake build fails with: But the other builds run fine and that was the whole point of this PR - to bring the tests from master here and to add CMake build with tests to CI. Both are done, so I suggest to merge this to your branch now and to continue in OSGeo#348. As for merging, I suggest Rebase and merge here to have the individual commits for review if needed, but I have no strong opinion on that (we'll Squash and merge in the main repo anyway). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rkanavath I'm opening this as a PR against the branch in your repo. I did a rebase to the latest master, so there is a lot of changes comparing to your branch. If you rebase to master and force push to yours, this will show a proper diff. I can also force push to your branch if you are fine with that. Please, let me know.
This adds CI, but does not change any code. It is basically what was here, but now it is natively part of the code and will be visible in the PR.
You don't have GitHub Actions enabled, but you can see the tests running in my fork. Like before, the build runs, but grass executable (grass79, grass.py, ...) is not in the right place, so tests fail.