Skip to content

Comments

setup GitHub Actions to run the tests on every push and PR#18

Closed
szabgab wants to merge 1 commit intorjbs:mainfrom
szabgab:github-actions
Closed

setup GitHub Actions to run the tests on every push and PR#18
szabgab wants to merge 1 commit intorjbs:mainfrom
szabgab:github-actions

Conversation

@szabgab
Copy link

@szabgab szabgab commented Jan 24, 2026

No description provided.

@szabgab
Copy link
Author

szabgab commented Feb 1, 2026

BTW I am sending these PRs as part of the OSDC Perl project

@rjbs
Copy link
Owner

rjbs commented Feb 5, 2026

Thanks, Gábor. Most of my dists use Dist-Zilla, and then have a stock "test with lots of perls" automation I use. I think I'll make a quick pass at making this work that way, just for uniformity.

If I can't, I'll merge this: it's better than waiting around for me forever!

@szabgab
Copy link
Author

szabgab commented Feb 5, 2026

Do you mean you have a "standard" CI that you use? I could copy that from one of your other modules.

@rjbs
Copy link
Owner

rjbs commented Feb 9, 2026

I do have a standard CI workflow, but you can't just copy it in, because it relies on the dist using Dist::Zilla. That's what I need to fix. You can read more here: https://rjbs.cloud/blog/2024/06/dzil-workflower/

I'll give the dzil-ing a go now…

@rjbs
Copy link
Owner

rjbs commented Feb 9, 2026

I've largely done this in #21

Problem: I made the optional prereqs into Recommends, which my CI will try to install, which fails on 5.12+5.16, because MIME::Types now requires 5.16. Pretty tempted to just bump the version on MIME::Lite, but will give a quick look to making this more optional later today. Work calls.

@rjbs
Copy link
Owner

rjbs commented Feb 11, 2026

I've fixed the prereq issue and merged #21, getting CI runs across all supported perls. I'm not 100% happy, because it won't test things requiring optional features. Needs some more support in the dzil-actions tooling, probably something like:

  • first install required modules
  • then try to install recommended and suggested modules, but do not abort on failure
  • then test

@rjbs rjbs closed this Feb 11, 2026
@szabgab
Copy link
Author

szabgab commented Feb 11, 2026

Great. Would you mind allowing the issues here on GitHub? It is easier than using RT. Especially for things that came up during our live session:

  • The fold function is never used in the code nor is it mentioned in the docs. Shall we remove it?
  • Shall we remove #!/usr/bin/perl from the tests? They not needed there.
  • Shall we split the packages into separate files?

@rjbs
Copy link
Owner

rjbs commented Feb 20, 2026

@szabgab Sorry, I somehow missed your last message.

I have turned on issues here, thanks for mentioning it. I really don't like using rt.cpan.org

Your suggested changes sound reasonable to me. PRs welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants