fix(ci): resolve pnpm/action-setup version conflict#83
Merged
Conversation
|
🚅 Environment secure-exec-pr-83 in rivet-frontend has no services deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI fails on every commit (including
main) at thepnpm/action-setupstep, before any build runs:pnpm/action-setup@v4refuses to run when the pnpm version is specified in two places:.github/workflows/ci.yml— the action'sversion: latestinputpackage.json—"packageManager": "[email protected]"When both are present, the action errors out rather than guessing which to honor.
Fix
Remove the
version:input from thepnpm/action-setupstep inci.ymlso the action reads the version solely frompackageManagerinpackage.json— the recommended single-source-of-truth configuration.This un-breaks CI repo-wide.
Notes
publish.yamlworkflow'spnpm/action-setupsteps already have noversion:input, so they were never affected and are left untouched..npmrcor other competing pnpm-version source;packageManageris now the only place the version is declared.