Migrate per-VM resource limits + virtualized identity from env to the BARE wire#82
Merged
Conversation
|
🚅 Environment secure-exec-pr-82 in rivet-frontend has no services deployed. |
NathanFlurry
force-pushed
the
env-vs-bare-migration
branch
2 times, most recently
from
June 19, 2026 11:07
2756e21 to
ac7a6f4
Compare
NathanFlurry
force-pushed
the
env-vs-bare-migration
branch
from
June 19, 2026 11:54
ac7a6f4 to
eb4a2bb
Compare
NathanFlurry
force-pushed
the
env-vs-bare-migration
branch
from
June 19, 2026 11:58
eb4a2bb to
ee175f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classifies which per-VM settings belong on the ambient
AGENT_OS_*env channel vs the BARE wire / structured request, encodes the rule inCLAUDE.md, and migrates the resource limits and virtualized identity families off env onto typed/structured channels.Migrated to the wire
*ExecutionLimitsrequest fields, sourced fromCreateVmConfig→VmLimits.AGENT_OS_WASM_MAX_STACK_BYTESdead cap (was written to env, never read) and a latent disconnection (wire limit fields were parsed but never plumbed → engine silently used defaults).process.{pid,ppid,uid,gid}interpolated into the runtime shim;os.{cpus,totalmem,freemem,homedir,userInfo,…}via the__agentOsVirtualOsstructured global the shim sets. TheAGENT_OS_VIRTUAL_{PROCESS,OS}_*env inserts are removed;osPOSIX env (HOME/USER/SHELL) is kept (bucket-2 standard env). Thev8-bridgebundle is regenerated from source.Not migrated (deferred, documented)
Isolation policy (
GUEST_PATH_MAPPINGS,EXTRA_FS_*_PATHS,ALLOWED_NODE_BUILTINS,LOOPBACK_EXEMPT_PORTS,WASM_PERMISSION_TIER) stays on env — bucket 3 but not yet moved.PARENT_NODE_ALLOW_*are dead (defined + scrubbed, never read).Testing
builtin_conformance::os_resource_limits_are_vm_scoped): a guest'sos.cpus/totalmem/freememreflect the configured VM resource limits, andos.userInfo().username/os.homedir()reflect the configured VM identity (distinct from the loader'sroot//rootdefaults) — exercising the realguestOs/import ospath through the sidecar.cargo check --workspace --all-targetsclean; fullcargo test -p secure-exec-executiongreen; sidecar suites green except 3 pre-existing/environmental failures (TLS-over-loopback, a child-process SIGABRT signal test, a pyodide asset-resolution test) — each verified to fail identically onmain.