fix(ci): install build-tools workspace deps in the bench workflow#214
Merged
NathanFlurry merged 3 commits intoJul 2, 2026
Conversation
…s via event The sidecar drains process output before emitting process_exited and the frame stream + event pump are FIFO, so once the exit event is observed no trailing output can follow it; the host-side quiet-turn drain (2 turns at 10ms) only remains for the snapshot-poll fallback exit path. Also stop awaiting signal-state refreshes on the exec critical path (start + first output) — kill paths await the in-flight refresh instead — and clean up the parked refresh in finishProcess so fallback exits release it too. Warm host-driven exec p50: node -e '' 30ms -> ~17ms, wasm true 52ms -> 39ms; whole wasm-command-floor lane down ~13ms/row; bench:gate green. New regression test: 10 sequential fast-exit 64KiB stdout captures.
Bake the constant wasm runner + wasi shim (~300KB of JS previously recompiled per exec) into the per-process V8 userland snapshot via guest_runtime.snapshot_userland_code, keyed and cached process-wide. Mode env AGENTOS_WASM_SNAPSHOT_RUNNER=auto|block|off: auto probes the snapshot cache without blocking (async warm kicked once per process) and falls back to the byte-identical inline runner until ready, so the cold path is unchanged. The sync-RPC glue is re-evaluated per exec (the snapshot-baked copy cannot bind session bridge fns). Module bytes are now base64-encoded once per module in a bounded, fingerprint-validated cache (64 entries, warn on evict, debug log reports per-entry and cumulative cache bytes) instead of fs::read+encode per exec. Adds AGENTOS_V8_SESSION_PHASES timers (snapshot_get / blob_clone / isolate_new / user_code_execute) and a measured NOTE against EagerCompile at snapshot build (moves cost to isolate deserialize). Warm wasm floor p50: true 39->33ms, pwd 48->43ms, ls-empty 81->75ms, date-version 127->115ms (52/62/96/140 before PR #212); cold first-exec improved; wasm suite green; bench:gate green. Remaining floor is isolate-per-exec + module decode — pooling tracked as Stage C.
Member
Author
This was referenced Jul 2, 2026
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-214
July 2, 2026 18:53
Destroyed
NathanFlurry
force-pushed
the
stack/fix-ci-install-build-tools-workspace-deps-in-the-bench-workflow-yuvtorxt
branch
from
July 2, 2026 19:08
a1fb4da to
8eae9c4
Compare
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-214
July 2, 2026 19:08
Destroyed
This was referenced Jul 2, 2026
The filtered install (--filter @secure-exec/benchmarks...) omitted packages/build-tools, so every bench-gate run died in the v8-bridge build script (missing Node dependencies) before gating anything — the PR gate has never actually run green on CI.
NathanFlurry
force-pushed
the
stack/fix-ci-install-build-tools-workspace-deps-in-the-bench-workflow-yuvtorxt
branch
from
July 2, 2026 20:05
8eae9c4 to
fc5d69a
Compare
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-214
July 2, 2026 20:05
Destroyed
|
🚅 Deployed to the secure-exec-pr-214 environment in secure-exec
|
This was referenced Jul 2, 2026
NathanFlurry
changed the base branch from
stack/feat-execution-snapshot-baked-wasm-runner-userland-osswtnlq
to
main
July 2, 2026 23:42
NathanFlurry
deleted the
stack/fix-ci-install-build-tools-workspace-deps-in-the-bench-workflow-yuvtorxt
branch
July 2, 2026 23:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filtered install (--filter @secure-exec/benchmarks...) omitted
packages/build-tools, so every bench-gate run died in the v8-bridge build
script (missing Node dependencies) before gating anything — the PR gate has
never actually run green on CI.