Skip to content

fix(ci): use a fixed revision for skywalking eyes#8172

Merged
mergify[bot] merged 1 commit intomainfrom
bz/fixed-skywalking-eyes-revision
Feb 24, 2023
Merged

fix(ci): use a fixed revision for skywalking eyes#8172
mergify[bot] merged 1 commit intomainfrom
bz/fixed-skywalking-eyes-revision

Conversation

@BugenZhao
Copy link
Copy Markdown
Contributor

@BugenZhao BugenZhao commented Feb 24, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Seems the recent changes in skywalking-eyes have broken the GitHub Actions workflow (apache/skywalking-eyes#150). Anyway it's not a good practice to use the main branch, let's use a fixed revision for it.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

~~- [ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

~~

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Feb 24, 2023
@mergify mergify bot merged commit 3735a4f into main Feb 24, 2023
@mergify mergify bot deleted the bz/fixed-skywalking-eyes-revision branch February 24, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jon-chuang jon-chuang Awaiting requested review from jon-chuang

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

1 more reviewer

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BugenZhao @liurenjie1024