Skip to content

Create CONTRIBUTING file #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
Jul 22, 2020
Merged

Create CONTRIBUTING file #42

3 commits merged into from
Jul 22, 2020

Conversation

@ghost
Copy link

@ghost ghost commented Jul 21, 2020

No description provided.

@ghost ghost requested a review from penguinwu July 21, 2020 00:08
penguinwu
penguinwu reviewed Jul 21, 2020
View reviewed changes
@ghost ghost force-pushed the contributing branch 2 times, most recently from 4900807 to b259ec2 Compare July 21, 2020 17:32
@obycode
Add test script, test-riscv.sh
b259ec2 
Add a dockerfile for building v8 and move the analyze tool into the
v8-riscv-tools directory, along with a README explaining how to use each
of the tools.
penguinwu
penguinwu approved these changes Jul 21, 2020
View reviewed changes
Copy link

@penguinwu penguinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 82d3490 into riscv-porting-dev Jul 22, 2020
@ghost ghost deleted the contributing branch July 22, 2020 01:03
luyahan pushed a commit to luyahan/v8 that referenced this pull request Sep 2, 2025
Version 13.4.114.21
4f282ae 
Version incremented at https://cr-buildbucket.appspot.com/build/8720524453977548977

Change-Id: I1b483b35dcf02ce4b6e5d7f5d7d81f447bff5621
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6351173
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.4@{riscv-collab#42}
Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{riscv-collab#1}
Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@penguinwu @obycode