mulw sign extends its inputs #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change any test suite failures, but it does match what the ISA does and I'm assuming that as we sort out the mul/mulh differences between RISC-V and MIPS that this will become relevant. Signed-off-by: Palmer Dabbelt <[email protected]>
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Aug 6, 2020
ghost
pushed a commit
that referenced
this pull request
Aug 28, 2020
ghost
pushed a commit
that referenced
this pull request
Oct 14, 2020
ghost
pushed a commit
that referenced
this pull request
Nov 11, 2020
luyahan
pushed a commit
to luyahan/v8
that referenced
this pull request
Nov 30, 2020
ghost
pushed a commit
that referenced
this pull request
Dec 3, 2020
ghost
pushed a commit
that referenced
this pull request
Dec 9, 2020
ghost
pushed a commit
that referenced
this pull request
Jan 13, 2021
ghost
pushed a commit
that referenced
this pull request
Jan 26, 2021
luyahan
pushed a commit
to luyahan/v8
that referenced
this pull request
Jan 27, 2021
luyahan
pushed a commit
to luyahan/v8
that referenced
this pull request
Feb 1, 2021
ghost
pushed a commit
that referenced
this pull request
Feb 1, 2021
ghost
pushed a commit
that referenced
this pull request
Feb 3, 2021
luyahan
pushed a commit
to luyahan/v8
that referenced
this pull request
Feb 7, 2021
luyahan
pushed a commit
to luyahan/v8
that referenced
this pull request
Feb 9, 2021
ghost
pushed a commit
that referenced
this pull request
Feb 9, 2021
luyahan
pushed a commit
to luyahan/v8
that referenced
this pull request
Sep 2, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8721674469761925473 Change-Id: Ib61ba1015a55bde6258f7a25598769efa2e55cf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6311710 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.4@{riscv-collab#34} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{riscv-collab#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change any test suite failures, but it does match what the ISA
does and I'm assuming that as we sort out the mul/mulh differences between
RISC-V and MIPS that this will become relevant.
Signed-off-by: Palmer Dabbelt [email protected]