feat: Added MapEnumValueAttribute and support for explicit enum value mapping#468
Conversation
…n\not be found and GetEnumValue to return the TypedConstant if enum reflection typ cannot be found.
peteraritchie
changed the title
There was a problem hiding this comment.
Thank you for this great contribution! 🚀 I appreciate your effort in working on this issue.
I added my review comments. Feel free to challenge any feedback provided.
FYI: Until your first contribution to this organization is merged, I need to manually approve pipeline runs...
Once you've made the necessary adjustments, feel free to ping me for another review. Keep up the good work!
…me source enum value
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3.0.3 to 3.2.0. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v3.0.3...v3.2.0) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Verify.XUnit](https://github.com/VerifyTests/Verify) from 20.0.0 to 20.3.0. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@20.0.0...20.3.0) --- updated-dependencies: - dependency-name: Verify.XUnit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
latonz
left a comment
latonz
left a comment
There was a problem hiding this comment.
Thank you for the updates 😊
Sorry I only caught some review feedbacks on this second review...
…t match enums types used in method
Codecov Report
@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 92.08% 92.41% +0.33%
==========================================
Files 135 141 +6
Lines 4282 4496 +214
Branches 591 574 -17
==========================================
+ Hits 3943 4155 +212
- Misses 225 227 +2
Partials 114 114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@peteraritchie the integration test snapshots for older frameworks have some differences which need to be fixed before merging. You can download the received snapshots of the github action here: artifact verify-test-results. |
|
@peteraritchie Thank you for the updates 😊 Could you rebase onto main? And then we are ready to merge 🎉 |
|
Any chance of getting this out soon in a new prerelease I'm currently migrating from AutoMapper and have a need for this. I'd like to test this as soon as possible. |
|
@tore-hammervoll-spv we plan to release |
|
🎉 This PR is included in version 2.9.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
Added MapEnumValueAttribute and support for explicit enum value mapping
Description
Fixes #336
Checklist