fix: respect Use configuration on read-only collection members to improve reported diagnostics#2356
Merged
Conversation
When a member mapping referenced a mapping by name (Use = ...) that is a new instance mapping, and the target member was a read-only collection or dictionary (e.g. a protobuf MapField), Mapperly silently ignored the configuration and built an implicit existing target mapping instead, producing a confusing RMG020 diagnostic. The referenced new instance mapping is now respected: it is assigned for settable members and reports RMG009 (cannot map to read only member) when the target cannot be set, instead of being silently ignored. Closes riok#2352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a member mapping referenced a mapping by name (Use = ...) that is a new instance mapping, and the target member was a read-only collection or dictionary (e.g. a protobuf MapField), Mapperly silently ignored the configuration and built an implicit existing target mapping instead, producing a confusing RMG020 diagnostic.
The referenced new instance mapping is now respected: it is assigned for settable members and reports RMG009 (cannot map to read only member) when the target cannot be set, instead of being silently ignored.
Closes #2352
Checklist