fix: detect MaybeNull/AllowNull on properties from referenced assemblies#2333
Merged
Merged
Conversation
For symbols loaded from metadata, Roslyn exposes the MaybeNull/AllowNull flow attributes on the getter return value / setter value parameter instead of the property itself. SymbolAccessor only checked the property symbol, so cross-assembly source properties were treated as non-nullable, omitting the null guard and producing CS8601. Add TryHasGetAttribute/TryHasSetAttribute helpers that also inspect the accessors and use them in IsReadNullable/IsWriteNullable. Fixes riok#2192
latonz
force-pushed
the
fix/2192-maybenull-cross-assembly
branch
from
June 22, 2026 15:23
a3eacde to
b326c23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For symbols loaded from metadata, Roslyn exposes the MaybeNull/AllowNull flow attributes on the getter return value / setter value parameter instead of the property itself. SymbolAccessor only checked the property symbol, so cross-assembly source properties were treated as non-nullable, omitting the null guard and producing CS8601.
Add TryHasGetAttribute/TryHasSetAttribute helpers that also inspect the accessors and use them in IsReadNullable/IsWriteNullable.
Fixes #2192
Checklist