feat: projection expression support#2141
Merged
Merged
Conversation
latonz
requested changes
Feb 5, 2026
latonz
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this contribution! ❤️ Very nice implementation.
I added my feedback.
Dreamescaper
marked this pull request as ready for review
February 7, 2026 14:21
Contributor
Author
|
Thanks a lot for your review! Hopefully, I've addressed all your comments, and marked PR as Ready For Review. |
latonz
requested changes
Feb 12, 2026
latonz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates. There are just a few small fixes required, and then we should be ready to merge.
Contributor
|
Regarding the failing tests:
|
Contributor
Author
|
Hopefully I have fixed all those issues! |
latonz
approved these changes
Feb 17, 2026
Contributor
|
Thank you for this great contribution 🥳 |
|
Do we know what release this will be included in? |
Contributor
|
It is available as part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Expression<Func<TSource, TTarget>> mapping support
Description
Adds support for generating
Expression<Func<TSource, TTarget>>mappings directly:Implementation
UserDefinedExpressionMethodMapping- Handles parameterless methods returning Expression, extracting source/target from type argumentsExpressionMapping- Generates lambda with nullable pragmas (same pattern as IQueryable)InlineExpressionMappingBuilderContextfor expression tree buildingvs #951
PR #951 modified IQueryable to call a generated Expression method, requiring a "void source hack" throughout core classes.
This PR keeps Expression mappings separate from IQuaryable. They share implementation details, but still separate branches.
"void source hack" is still present here, but I have tried to keep it's impact limited to
UserDefinedExpressionMethodMappingtype only.Fixes #733
Checklist