Bugfix: Stackoverflow on readonly self reference#1991
Merged
latonz merged 7 commits intoNov 17, 2025
Conversation
Contributor
Author
|
Hi @latonz I wanted to fix this, too, but it was a hard nut to crack. In the end, I found this solution, which works.
|
Contributor
|
Thank you for this contribution. It looks good to me. Can't the same happen for init only members, ctor parameters and expression mappings? |
Contributor
Author
|
For the init-only members, this can also occur if there is a read-only file in the path. I added tests where both are init-only, and one is read-only. |
latonz
approved these changes
Nov 17, 2025
Contributor
|
Thank you for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix: Stackoverflow on readonly self reference
Description
This PR fixes the case in the mapping when there is a circular reference of existing target mapping and no writable property along the path.
Fixes #1882
Checklist