Implement runAsync (wait for thread)#27
Merged
ringabout merged 1 commit intoringabout:masterfrom Apr 17, 2023
Merged
Conversation
ringabout
reviewed
Apr 17, 2023
| asyncdispatch.poll(0) | ||
|
|
||
| if threadVars.event.isSome(): | ||
| threadVars.event.get().trigger() |
ringabout
approved these changes
Apr 17, 2023
Owner
ringabout
left a comment
ringabout
left a comment
There was a problem hiding this comment.
LGTM. It would be nice to have a simple documentation or example here or in the Prologue for its usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
Implementation requires threading and the http server runs always in a background thread, main thread returns a future that completes when the background thread terminates.