Closed
Conversation
ayaka14732
requested review from
LEOYoon-Tsaw,
William8915,
laubonghaudoi,
lotem,
sgalal and
tanxpyox
Collaborator
|
LGTM! - but if it makes the installer too big, I think a better way of doing it is incorporating the builder script to the CI workflow, so that we can keep this unspaced branch updated and usable as an optional module. |
Member
|
I'd really hope that someone fix it in librime rather than creating a duplicated dictionary for length>1 words. But I have to admit this works for now. |
Member
laubonghaudoi
left a comment
laubonghaudoi
left a comment
There was a problem hiding this comment.
目前有conflict，跟進更新之後就可以合併落master嘞
Collaborator
我都係覺得將呢個功能分開做另一個branch好啲——如果唔係個安裝包會有成40MB.... 加上已經寫好晒自動生成嘅script，應該可以用 Github Actions 實裝 (trigger on commit) |
Member
|
如果係噉嘅話，噉安裝教程嗰度要加多一個部分教點樣裝呢個branch |
Member
|
@ayaka14732 我係唔係可以先閂咗呢個 PR？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when using Putonghua pinyin (普通話拼音) to reverse lookup ni (你), there is a comment of its Cantonese pronunciation nei5. However, for words over one characters, like ni hao (你好), there is no comment of its Cantonese pronunciation. This is a known issue of librime: rime/home#500.
This pull request proposes a method that enables words over one characters to have comments when doing the reverse lookup by creating a new dictionary called
jyut6ping3_unspaced. The file is automatically generated fromjyut6ping3by running the Python scripttools/build_unspaced.py. The difference is that all the spaces are replaced by equal signs (=).The drawback of this method is that the dictionary will be stored twice in the repository. However, considering the benefits it provides, this change can be quite worthwhile.