Add Hook: "Commit script while keeping the selected transforms" （輸入預變換上屏時保留已接受的候選）#924
Merged
lotem merged 5 commits intorime:masterfrom Aug 26, 2024
Merged
Add Hook: "Commit script while keeping the selected transforms" （輸入預變換上屏時保留已接受的候選）#924lotem merged 5 commits intorime:masterfrom
lotem merged 5 commits intorime:masterfrom
Conversation
added 2 commits
August 8, 2024 22:56
Essential for Japanese Romaji-based input.
Contributor
|
已经支持的功能，请在我发的链结指向的wiki中搜关键字 commit_script_text |
xrq-phys
changed the title
Author
|
抱歉我描述功能有誤：應為 commit script時保留已接受的漢字 因為製作日文輸入時經常需要進行假名半保留，所以需要在前半部分已經完成compose selection（漢字）的情況下對後半部分保留precompose的預變換（假名） 已經更新最上方的PR描述 |
added 2 commits
August 10, 2024 09:20
Style
Style
ksqsf
approved these changes
Aug 17, 2024
Member
ksqsf
left a comment
ksqsf
left a comment
There was a problem hiding this comment.
LGTM。我贊同這是目前沒有且需要增設的功能。但是具體名字似可商榷，不過我也沒有更好的提議。:-)
Author
|
感謝！ 如果 |
Member
|
這個功能挺好的，不如讓 |
Do we need to keep that optional argument?
Author
|
原來如此。 已修改成 |
Member
|
合併了。謝謝。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Feature
Add Commit script while keeping the transforms: when
commit_script_text_keep_selectionis called, the morphed input goes to the box instead of raw inputs with previously accepted transformations keptEssential for Japanese Romaji-based input.
功能：當
commit_script_text_keep_selection被調用時（例如：時按下 Return），可實現預變換輸入上屏時保留已選漢字。
比較直接的應用是在使用 Rime 輸入日語時可以將 Romaji 預變換的假名上屏並保留已輸入的漢字。
E.g.
nyuuryokupuroguramuにゅうりょくぷろぐらむにゅうりょく→入力⬇️ Press Return ⬇️
Config used here: My customization of gkovacs/rime-japanese.
Unit test
Manual test
Code Review
Additional Info