Skip to content

chore: more detail log info when key_binder/bindings parsing errors happen#922

Merged
ksqsf merged 1 commit intorime:masterfrom
fxliang:keybinder
Aug 17, 2024
Merged

chore: more detail log info when key_binder/bindings parsing errors happen#922
ksqsf merged 1 commit intorime:masterfrom
fxliang:keybinder

Conversation

@fxliang
Copy link
Contributor

@fxliang fxliang commented Jul 26, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

make the warning information more useful when parsing errors happen.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@ksqsf ksqsf merged commit 3c1c478 into rime:master Aug 17, 2024
@fxliang fxliang deleted the keybinder branch September 24, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants