fix(vocabulary): Homophones sorting should be stable.#1079
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes unstable sorting behavior in the Rime dictionary vocabulary system that was causing homophones (words with same pronunciation) to be reordered unpredictably during table compilation when using sort: by_weight.
- Replaces
std::sortwithstd::stable_sortin template functions to maintain relative order of equivalent elements - Ensures consistent ordering of homophone candidates with equal weights
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eagleoflqj
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在编译 table 时,有时可以观察到
sort: by_weight的词典中,重码候选顺序会因为排序不稳定而乱掉,改为稳定排序即可修复。