Fix time spine first day/month use #8557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use time range with timezone format
begelundmuller
approved these changes
Dec 22, 2025
Contributor
begelundmuller
left a comment
begelundmuller
left a comment
There was a problem hiding this comment.
LGTM – but to validate and prevent regressions, can you add a reproducer test that fails for the old code and now works with this fix?
Contributor
|
Patch worthy? |
Member
Author
|
@mindspank yes |
pjain1
added a commit
that referenced
this pull request
Dec 22, 2025
* use first day, month use time range with timezone format * test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the use of first day and month in time spine.
Checklist: