fix: explain action not auto submitting prompt #8554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
added
the
blocker
web-common/src/features/dashboards/url-state/url-state-variations.spec.ts
Show resolved
Hide resolved
ericpgreen2
approved these changes
Dec 23, 2025
Comment on lines
74
to
75
| editor.commands.setContent(prompt); | ||
| draftMessageStore.set(prompt); |
Contributor
There was a problem hiding this comment.
It looks like this draftMessageStore.set command is redundant to editor.commands.setContent. Is it necessary? Can you add a comment if so?
Collaborator
Author
There was a problem hiding this comment.
This is to avoid having to wait for draftMessageStore to update. Will add a comment
Collaborator
Author
There was a problem hiding this comment.
Actually it is not needed since I added tick. Removing it
AdityaHegde
added a commit
that referenced
this pull request
Dec 24, 2025
* fix: explain action not auto submitting prompt * Fix lint * Fix merge issue * Remove redundant set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently explain action on a measure just populates the chat input. To avoid another user action we should submit the chat directly.
Checklist: