Skip to content

Fix 'NaN' serialization error in query_metrics_view tool #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
begelundmuller merged 1 commit into from
Dec 17, 2025
Merged

Fix 'NaN' serialization error in query_metrics_view tool #8521

begelundmuller merged 1 commit into from
Dec 17, 2025

Conversation

@begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Dec 16, 2025

Fixes this error observed in production:

failed to marshal result for tool "query_metrics_view": json: unsupported value: NaN

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller self-assigned this Dec 16, 2025
nishantmonu51
nishantmonu51 approved these changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@begelundmuller begelundmuller merged commit 6c06b55 into main Dec 17, 2025
16 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/fix-nan-tool-result branch December 17, 2025 08:48
begelundmuller added a commit that referenced this pull request Dec 17, 2025
@begelundmuller
Fix 'NaN' serialization error in query_metrics_view tool (#8521)
2e72300
k-anshul pushed a commit that referenced this pull request Dec 18, 2025
@begelundmuller @k-anshul
Fix 'NaN' serialization error in query_metrics_view tool (#8521)
5a79ee1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nishantmonu51 nishantmonu51 nishantmonu51 approved these changes

@k-anshul k-anshul Awaiting requested review from k-anshul

Assignees

@begelundmuller begelundmuller

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@begelundmuller @nishantmonu51