Skip to content

[APP-652] fix: canvas component map reactivity #8503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briangregoryholmes merged 4 commits into from
Dec 15, 2025
Merged

[APP-652] fix: canvas component map reactivity #8503

briangregoryholmes merged 4 commits into from
Dec 15, 2025

Conversation

@briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Dec 13, 2025 •
edited
Loading

Fixes a reactivity issue with the component map on CanvasEntity by wrapping it in a writable.

  • Updates test to catch that sidebar properties successfully update when switching charts

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@briangregoryholmes briangregoryholmes self-assigned this Dec 13, 2025
AdityaHegde
AdityaHegde approved these changes Dec 15, 2025
View reviewed changes
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits.

@briangregoryholmes briangregoryholmes merged commit f7b88d7 into main Dec 15, 2025
13 of 14 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/tweak-canvas-component-map branch December 15, 2025 15:28
@ericokuma
Copy link
Contributor

ericokuma commented Dec 15, 2025

Could we patch this in?

@briangregoryholmes
Copy link
Contributor Author

briangregoryholmes commented Dec 15, 2025 •
edited
Loading

This bug was on main not on release-0.78 or release-0.77. Patch is only necessary if we plan on patching in the default filters PR to 0.78.

briangregoryholmes added a commit that referenced this pull request Dec 17, 2025
@briangregoryholmes
[APP-652] fix: canvas component map reactivity (#8503)
e1bbcea 
* fix: improve component map reactivity

* remove logs

* fix types and test

* make function generic
k-anshul pushed a commit that referenced this pull request Dec 18, 2025
@briangregoryholmes @k-anshul
[APP-652] fix: canvas component map reactivity (#8503)
06aae7a 
* fix: improve component map reactivity

* remove logs

* fix types and test

* make function generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdityaHegde AdityaHegde AdityaHegde approved these changes

@ericokuma ericokuma Awaiting requested review from ericokuma

Assignees

@briangregoryholmes briangregoryholmes

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@briangregoryholmes @ericokuma @AdityaHegde