Tech design: AI citations refactor #8502
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2025
ericpgreen2
changed the title
AdityaHegde
reviewed
Dec 17, 2025
| Change analyst agent instructions to use the XML-style cite syntax: | ||
|
|
||
| ```diff | ||
| - Every 'query_metrics_view' result includes an 'open_url' field - use this as a markdown link |
Collaborator
There was a problem hiding this comment.
This might lead to issues when using the MCP server outside of rill UI no? How would the LLM know to replace it with a link or add citations in something like claude desktop?
|
|
||
| <Markdown | ||
| md={content} | ||
| plugins={[citePlugin(citations)]} |
Collaborator
There was a problem hiding this comment.
How does this actually render the CitationLink? The docs are bit sparse for this library.
|
|
||
| ```typescript | ||
| // marked extension - outputs HTML placeholders | ||
| marked.use({ |
Collaborator
There was a problem hiding this comment.
If we are doing the backend refactor I vote for moving away from this "rewrite" method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review. Not to merge to
main. Open to feedback!