Skip to content

[ENG-998] fix: improve support for canvases without time dimension #8481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericokuma merged 2 commits into from
Dec 11, 2025
Merged

[ENG-998] fix: improve support for canvases without time dimension #8481

ericokuma merged 2 commits into from
Dec 11, 2025

Conversation

@briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Dec 10, 2025 •
edited
Loading

This PR fixes an issue where Chart and KPI widgets would not properly fetch data if the underlying metrics view lacked a time dimension. This is a patch fix to merge if necessary, with the primary fix included as part of #8391

  • Hides primary time range and comparison pill when no metrics view with a time dimension exists

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@briangregoryholmes briangregoryholmes self-assigned this Dec 10, 2025
AdityaHegde
AdityaHegde approved these changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a code POV

@ericokuma ericokuma merged commit 5e9d9f5 into main Dec 11, 2025
14 of 15 checks passed
@ericokuma ericokuma deleted the bgh/improve-support-for-canvases-without-time-dimension branch December 11, 2025 04:16
@ericokuma
Copy link
Contributor

ericokuma commented Dec 11, 2025

LGTM

@ericokuma
Copy link
Contributor

ericokuma commented Dec 11, 2025

Whoops...I didn't mean to squash and merge...

@AdityaHegde
Copy link
Collaborator

AdityaHegde commented Dec 11, 2025

@ericokuma I think it should be fine. @briangregoryholmes can cherry pick if the other PR is not merged in time.

briangregoryholmes added a commit that referenced this pull request Dec 11, 2025
@briangregoryholmes
[ENG-998] fix: improve support for canvases without time dimension (#…
95b90e3 
…8481)

* fix: improve support for canvases without time dimension

* update heatmap chart provider
@briangregoryholmes briangregoryholmes mentioned this pull request Dec 15, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdityaHegde AdityaHegde AdityaHegde approved these changes

@ericokuma ericokuma Awaiting requested review from ericokuma

@royendo royendo Awaiting requested review from royendo

Assignees

@briangregoryholmes briangregoryholmes

Labels

Bug patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@briangregoryholmes @ericokuma @AdityaHegde