Skip to content

feat: tags in dims/measures #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
begelundmuller merged 3 commits into from
Dec 11, 2025
Merged

feat: tags in dims/measures #8476

begelundmuller merged 3 commits into from
Dec 11, 2025

Conversation

@mindspank
Copy link
Contributor

@mindspank mindspank commented Dec 10, 2025

adds tags to dims/measures

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

begelundmuller
begelundmuller reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also document the property in runtime/parser/schema/project.schema.yaml?

@mindspank mindspank self-assigned this Dec 10, 2025
begelundmuller
begelundmuller approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begelundmuller begelundmuller merged commit 9a23082 into main Dec 11, 2025
15 checks passed
@begelundmuller begelundmuller deleted the feat/tags-backend branch December 11, 2025 11:40
k-anshul pushed a commit that referenced this pull request Dec 18, 2025
@mindspank @k-anshul
feat: tags in dims/measures (#8476)
5416a28 
* feat: tags in dims/measures

* move prop

* docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

Assignees

@mindspank mindspank

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mindspank @begelundmuller