Skip to content

Fix Go test coverage by removing the GOEXPERIMENT=nocoverageredesign #8465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
begelundmuller merged 3 commits into from
Dec 8, 2025
Merged

Fix Go test coverage by removing the GOEXPERIMENT=nocoverageredesign #8465

begelundmuller merged 3 commits into from
Dec 8, 2025

Conversation

@begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Dec 8, 2025 •
edited
Loading

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller self-assigned this Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.62%. Comparing base (cda43d4) to head (ad2c45c).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8465      +/-   ##
==========================================
- Coverage   35.64%   35.62%   -0.02%     
==========================================
  Files         673      676       +3     
  Lines       81027    81870     +843     
==========================================
+ Hits        28882    29170     +288     
- Misses      47803    48328     +525     
- Partials     4342     4372      +30
Flag Coverage Δ
go 35.62% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

grahamplata
grahamplata approved these changes Dec 8, 2025
View reviewed changes
Copy link
Member

@grahamplata grahamplata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ran it locally with no issues

@begelundmuller begelundmuller merged commit 7a0e373 into main Dec 8, 2025
4 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/fix-go-cover branch December 8, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grahamplata grahamplata grahamplata approved these changes

Assignees

@begelundmuller begelundmuller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@begelundmuller @grahamplata