Skip to content

Conversation

@begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Dec 4, 2025

Previously, the validation would apply a TimeFloor to the default time dimension, which always coerced the type to a TIMESTAMP type.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller self-assigned this Dec 4, 2025
@begelundmuller begelundmuller requested a review from pjain1 December 4, 2025 15:42
@begelundmuller begelundmuller merged commit 934ad57 into main Dec 10, 2025
16 of 19 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/fix-time-dimension-schema branch December 10, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants