ClickHouse Cloud Port Selector (#8458)

royendo · web-flow · commit fc33bcbdaa9e · 2025-12-09T13:39:30.000-05:00
* only defaults SSL, Port is now selecatable dropdown bettwen 8443 and 9440

* update ui to match other inputs' hints

checked measure dimension drodpown which is using select and no discernable differences

* revert select

* setfontsize in the clickhousefform for consistnecy

* removefontSize

* return optional

* revert fontSize
diff --git a/runtime/drivers/clickhouse/clickhouse.go b/runtime/drivers/clickhouse/clickhouse.go
@@ -85,7 +85,7 @@ var spec = drivers.Spec{
 			DisplayName: "Port",
 			Description: "Port number of the ClickHouse server",
 			Placeholder: "9000",
-			Hint:        "Default port is 9000 for native protocol. Also commonly used: 8443 for ClickHouse Cloud (HTTPS), 8123 for HTTP",
+			Hint:        "Default ClickHouse ports: 9000 (native TCP), 8123 (HTTP). Secure/common alternatives: 9440 (native TCP + TLS) and 8443 (HTTPS, often used in ClickHouse Cloud/managed setups).",
 			Default:     "9000",
 		},
 		{
diff --git a/web-common/src/features/sources/modal/AddClickHouseForm.svelte b/web-common/src/features/sources/modal/AddClickHouseForm.svelte
@@ -244,7 +244,6 @@
       connectionTab === "parameters"
     ) {
       (values as any).ssl = true;
-      (values as any).port = "8443";
     }
 
     try {
@@ -400,14 +399,19 @@
                   id={propertyKey}
                   label={property.displayName}
                   placeholder={property.placeholder}
-                  optional={!property.required}
+                  optional={property.required}
                   secret={property.secret}
                   hint={property.hint}
                   errors={normalizeErrors($paramsErrors[propertyKey])}
                   bind:value={$paramsForm[propertyKey]}
                   onInput={(_, e) => onStringInputChange(e)}
                   alwaysShowError
-                  disabled={connectorType === "clickhouse-cloud" && isPortField}
+                  options={connectorType === "clickhouse-cloud" && isPortField
+                    ? [
+                        { value: "8443", label: "8443 (HTTPS)" },
+                        { value: "9440", label: "9440 (Native Secure)" },
+                      ]
+                    : undefined}
                 />
               {:else if property.type === ConnectorDriverPropertyType.TYPE_BOOLEAN}
                 <Checkbox
diff --git a/web-common/src/features/sources/modal/utils.ts b/web-common/src/features/sources/modal/utils.ts
@@ -85,7 +85,7 @@ export function hasOnlyDsn(
 
 /**
  * Applies ClickHouse Cloud-specific default requirements for connector values.
- * - For ClickHouse Cloud: enforces `ssl: true` and `port: "8443"`
+ * - For ClickHouse Cloud: enforces `ssl: true`
  * - Otherwise returns values unchanged
  */
 export function applyClickHouseCloudRequirements(
@@ -94,7 +94,7 @@ export function applyClickHouseCloudRequirements(
   values: Record<string, unknown>,
 ): Record<string, unknown> {
   if (connectorName === "clickhouse" && connectorType === "clickhouse-cloud") {
-    return { ...values, ssl: true, port: "8443" } as Record<string, unknown>;
+    return { ...values, ssl: true } as Record<string, unknown>;
   }
   return values;
 }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ var spec = drivers.Spec{`
`85`	`85`	`DisplayName: "Port",`
`86`	`86`	`Description: "Port number of the ClickHouse server",`
`87`	`87`	`Placeholder: "9000",`
`88`		`- Hint: "Default port is 9000 for native protocol. Also commonly used: 8443 for ClickHouse Cloud (HTTPS), 8123 for HTTP",`
	`88`	`+ Hint: "Default ClickHouse ports: 9000 (native TCP), 8123 (HTTP). Secure/common alternatives: 9440 (native TCP + TLS) and 8443 (HTTPS, often used in ClickHouse Cloud/managed setups).",`
`89`	`89`	`Default: "9000",`
`90`	`90`	`},`
`91`	`91`	`{`