revert (#8442)

mindspank · mindspank · commit c216bd928c57 · 2025-12-04T13:05:45.000+01:00
diff --git a/web-common/src/features/canvas/components/leaderboard/index.ts b/web-common/src/features/canvas/components/leaderboard/index.ts
@@ -16,7 +16,6 @@ import {
 import type { ExploreState } from "@rilldata/web-common/features/dashboards/stores/explore-state";
 import { DashboardState_ActivePage } from "@rilldata/web-common/proto/gen/rill/ui/v1/dashboard_pb";
 import {
-  MetricsViewSpecDimensionType,
   type V1MetricsViewSpec,
   type V1Resource,
 } from "@rilldata/web-common/runtime-client";
@@ -126,11 +125,7 @@ export class LeaderboardComponent extends BaseCanvasComponent<LeaderboardSpec> {
       metricsViewSpec?.measures?.slice(0, 1).map((m) => m.name as string) ?? []; // TODO: change to 3
 
     const dimensions =
-      [...(metricsViewSpec?.dimensions || [])]
-        .filter(
-          (d) =>
-            d.type === MetricsViewSpecDimensionType.DIMENSION_TYPE_CATEGORICAL,
-        )
+      metricsViewSpec?.dimensions
         ?.slice(0, 3)
         .map((d) => d.name || (d.column as string)) ?? [];
 
diff --git a/web-common/src/features/canvas/components/pivot/index.ts b/web-common/src/features/canvas/components/pivot/index.ts
@@ -11,7 +11,6 @@ import type {
 import type { ExploreState } from "@rilldata/web-common/features/dashboards/stores/explore-state";
 import { DashboardState_ActivePage } from "@rilldata/web-common/proto/gen/rill/ui/v1/dashboard_pb";
 import {
-  MetricsViewSpecDimensionType,
   type V1MetricsViewSpec,
   type V1Resource,
 } from "@rilldata/web-common/runtime-client";
@@ -177,10 +176,6 @@ export class PivotCanvasComponent extends BaseCanvasComponent<
 
     const dimensions =
       metricsViewSpec?.dimensions
-        ?.filter(
-          (d) =>
-            d.type === MetricsViewSpecDimensionType.DIMENSION_TYPE_CATEGORICAL,
-        )
         ?.slice(0, 3)
         .map((d) => d.name || (d.column as string)) ?? [];
 
@@ -213,12 +208,8 @@ export class PivotCanvasComponent extends BaseCanvasComponent<
     const allMeasures =
       metricsViewSpec?.measures?.map((m) => m.name as string) || [];
     const allDimensions =
-      metricsViewSpec?.dimensions
-        ?.filter(
-          (d) =>
-            d.type === MetricsViewSpecDimensionType.DIMENSION_TYPE_CATEGORICAL,
-        )
-        ?.map((d) => d.name || (d.column as string)) || [];
+      metricsViewSpec?.dimensions?.map((d) => d.name || (d.column as string)) ||
+      [];
 
     let newSpec: PivotSpec | TableSpec;
 
diff --git a/web-common/src/features/canvas/components/validators.ts b/web-common/src/features/canvas/components/validators.ts
@@ -1,7 +1,4 @@
-import {
-  MetricsViewSpecDimensionType,
-  type V1MetricsViewSpec,
-} from "@rilldata/web-common/runtime-client";
+import { type V1MetricsViewSpec } from "@rilldata/web-common/runtime-client";
 
 export const isMeasureValid = (
   metricsViewSpec: V1MetricsViewSpec,
@@ -17,12 +14,7 @@ export const isDimensionValid = (
   dimensionName: string,
 ): boolean => {
   return (
-    metricsViewSpec?.dimensions
-      ?.filter(
-        (d) =>
-          d.type === MetricsViewSpecDimensionType.DIMENSION_TYPE_CATEGORICAL,
-      )
-      .some((d) => d.name === dimensionName) || false
+    metricsViewSpec?.dimensions?.some((d) => d.name === dimensionName) || false
   );
 };
 
diff --git a/web-common/src/features/canvas/inspector/selectors.ts b/web-common/src/features/canvas/inspector/selectors.ts
@@ -7,10 +7,7 @@ import {
 import type { FileArtifact } from "@rilldata/web-common/features/entity-management/file-artifact";
 import { TIME_GRAIN } from "@rilldata/web-common/lib/time/config";
 import { isGrainBigger } from "@rilldata/web-common/lib/time/grains";
-import {
-  MetricsViewSpecDimensionType,
-  V1TimeGrain,
-} from "@rilldata/web-common/runtime-client";
+import { V1TimeGrain } from "@rilldata/web-common/runtime-client";
 import { derived } from "svelte/store";
 import { parseDocument } from "yaml";
 
@@ -41,10 +38,7 @@ export function useMetricFieldData(
       const displayMap: Record<string, { label: string; type: FieldType }> = {};
 
       const measures = metricsViewSpec?.measures ?? [];
-      const dimensions = (metricsViewSpec?.dimensions ?? []).filter(
-        (d) =>
-          d.type === MetricsViewSpecDimensionType.DIMENSION_TYPE_CATEGORICAL,
-      );
+      const dimensions = metricsViewSpec?.dimensions ?? [];
       const timeDimension = metricsViewSpec?.timeDimension;
 
       if (type.includes("measure")) {
