Conversation
Due to a scoping issue, timeouts were reported with the server's timeout, rather than the client's (if it was provided).
|
What do you mean by report? This effectively shortens the timeout for |
Contributor
Author
Yes, and that was the case prior to this PR. Unfortunately, prior to this PR, when a timeout was hit RPCQ would issue an error message that used the server's timeout rather than the client's timeout. So the client might see a misleading message (client provides a timeout but sees a different timeout in the error message). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a scoping issue, timeouts were reported with the server's
timeout, rather than the client's (if it was provided).