Conversation
Contributor
Author
|
@rien The quality of the text is preserved with this fix and the brightness is at the levels it was before the |
…t the original issue
itay-grudev
force-pushed
the
rescaled_grey16be_colors
branch
from
e979680 to
f34e513
Compare
Merged
rien
approved these changes
Jan 10, 2024
Owner
rien
left a comment
rien
left a comment
There was a problem hiding this comment.
Ah yes, that looks way better indeed. Thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-scales the
grey16becolors usingffmpeg'scolorlevelsfilter to directly reverse the original issue causing the image to be really dark.Importantly, using this method the quality of small details is preserved, as opposed to
gamma,brightnessandcontrastfilters which significantly reduce the quality of text and small details and/or do not achieve the desired brightening effect.Current solution on
mainsince #100:Improved version with
colorlevels:Fixes: #96