Skip to content

Comments

[v3.0] Support activerecord 8.0#504

Merged
winebarrel merged 1 commit intoridgepole:3.0from
tnir:tn-support-rails-80
Nov 4, 2024
Merged

[v3.0] Support activerecord 8.0#504
winebarrel merged 1 commit intoridgepole:3.0from
tnir:tn-support-rails-80

Conversation

@tnir
Copy link
Contributor

@tnir tnir commented Oct 20, 2024

@coveralls
Copy link

Coverage Status

coverage: 97.065%. remained the same
when pulling 07fe4bd on tnir:tn-support-rails-80
into 37ee768 on ridgepole:2.0.

@winebarrel
Copy link
Member

winebarrel commented Oct 20, 2024

I created v2.1 branch. Could you use that as the base of the PR branch?
https://github.com/ridgepole/ridgepole/tree/2.1

@tnir tnir changed the base branch from 2.0 to 2.1 October 20, 2024 10:15
@tnir tnir changed the title Support activerecord 8.0 [v2.1] Support activerecord 8.0 Oct 20, 2024
@tnir
Copy link
Contributor Author

tnir commented Oct 20, 2024

@winebarrel Make sense. Changed the target branch to 2.1 branch.

@tnir
Copy link
Contributor Author

tnir commented Oct 23, 2024

@winebarrel I guess you should have created v2.2 branch instead of v2.1, shouldn't you? v2.1 branch should be preserved for Rails 7.2?

@winebarrel
Copy link
Member

@tnir Sorry for the late reply.
I agree with your idea and have changed the branch name from 2.1 to 3.0.

@winebarrel winebarrel merged commit 1422219 into ridgepole:3.0 Nov 4, 2024
@winebarrel winebarrel changed the title [v2.1] Support activerecord 8.0 [v3.0] Support activerecord 8.0 Nov 4, 2024
@tnir tnir deleted the tn-support-rails-80 branch November 7, 2024 14:40
@tnir
Copy link
Contributor Author

tnir commented Nov 7, 2024

Thanks! 🎉

@winebarrel
Copy link
Member

v3.0.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants