Skip to content

Comments

Support rails 7.1#441

Merged
winebarrel merged 7 commits intoridgepole:2.0from
alpaca-tc:support-rails-7-1
Oct 22, 2023
Merged

Support rails 7.1#441
winebarrel merged 7 commits intoridgepole:2.0from
alpaca-tc:support-rails-7-1

Conversation

@alpaca-tc
Copy link
Contributor

@alpaca-tc alpaca-tc commented Oct 11, 2023

I have confirmed that it works in two local projects, but have not yet checked it in production.
Perhaps this should do a BETA release before doing a major release.

@coveralls
Copy link

coveralls commented Oct 11, 2023

Coverage Status

coverage: 96.76% (+0.3%) from 96.488% when pulling 1c86ac3 on alpaca-tc:support-rails-7-1 into 153049a on ridgepole:2.0.

unsigned is not a valid syntax in PostgreSQL and has been prohibited since rails 7.1.
Since it has not changed anything in PostgreSQL since before, I think it is appropriate to remove it from the code.

related: rails/rails#46178
@alpaca-tc alpaca-tc changed the base branch from 1.2 to 2.0 October 14, 2023 14:53
@alpaca-tc alpaca-tc marked this pull request as ready for review October 14, 2023 15:04
@alpaca-tc
Copy link
Contributor Author

@winebarrel I have created a PR for rails 7.1 😄

@winebarrel winebarrel self-requested a review October 22, 2023 01:43
@winebarrel winebarrel self-assigned this Oct 22, 2023
Copy link
Member

@winebarrel winebarrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@winebarrel winebarrel merged commit d43f8de into ridgepole:2.0 Oct 22, 2023
@winebarrel
Copy link
Member

v2.0.0.beta has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants