Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to parse environment variable in config.yaml #109

Closed
deviarchscs opened this issue Jan 5, 2024 · 2 comments · Fixed by #110
Closed

Ability to parse environment variable in config.yaml #109

deviarchscs opened this issue Jan 5, 2024 · 2 comments · Fixed by #110

Comments

@deviarchscs
Copy link

Problem

I have a scenario where I have to use the same script multiple times with different parameters. (ie: I have to count emails number in several mailboxes).
The script_exporter is able to do that well but it is insecure and cumbersome to do this since I have to hardcode passwords directly in the config file. Ssee example below:

    scripts:
      - name: myemail_1
        command: java
        args:
          - -jar
          - /usr/src/CountMail.jar
        env:
          EMAIL: [email protected]
          EMAIL_USERNAME: my_username_1
          EMAIL_PASSWORD: my_password_1
      - name: myemail_2
        command: java
        args:
          - -jar
          - /usr/src/CountMail.jar
        env:
          EMAIL: [email protected]
          EMAIL_USERNAME: my_username_2
          EMAIL_PASSWORD: my_password_2
      - name: myemail_3
        command: java
        args:
          - -jar
          - /usr/src/CountMail.jar
        env:
          EMAIL: [email protected]
          EMAIL_USERNAME: my_username_3
          EMAIL_PASSWORD: my_password_3

Solution

The script exporter should be able to parse environment variables written in the "args" and "env" section of a script inside the config.yaml file. This way, no sensitive information would be written onto the config file (and it will also improve readability IMO)

Example:

Prerequisites existing environment variables:

MYEMAIL_1
MYEMAIL_USERNAME_1
MYEMAIL_PASSWORD_1
MYEMAIL_2
MYEMAIL_USERNAME_2
MYEMAIL_PASSWORD_2
MYEMAIL_3
MYEMAIL_USERNAME_3
MYEMAIL_PASSWORD_3

    scripts:
      - name: myemail_1
        command: java
        args:
          - -jar
          - CountMail.jar
        env:
          EMAIL: ${MYEMAIL_1} 
          EMAIL_USERNAME: ${MYEMAIL_USERNAME_1}
          EMAIL_PASSWORD: ${MYEMAIL_PASSWORD_1}
      - name: myemail_2
        command: java
        args:
          - -jar
          - /usr/src/CountMail.jar
        env:
          EMAIL: ${MYEMAIL_2}
          EMAIL_USERNAME: ${MYEMAIL_USERNAME_2}
          EMAIL_PASSWORD: ${MYEMAIL_PASSWORD_2}
      - name: myemail_3
        command: java
        args:
          - -jar
          - /usr/src/CountMail.jar
        env:
          EMAIL: ${MYEMAIL_3}
          EMAIL_USERNAME: ${MYEMAIL_USERNAME_3}
          EMAIL_PASSWORD: ${MYEMAIL_PASSWORD_3}
@deviarchscs
Copy link
Author

@ricoberger any thoughts?
Thank you!

@ricoberger ricoberger mentioned this issue Jan 10, 2024
Merged
@ricoberger
Copy link
Owner

Hi @deviarchscs, I like the idea and this should be supported once #110 is merged.

Once it is merged, I will publish a new version. Please let me know if sth. isn't working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse Environment Variables in Configuration File ricoberger/script_exporter
2 participants
@ricoberger @deviarchscs