Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Config class #25

Closed
rickard2 opened this issue Apr 6, 2013 · 3 comments
Closed

Refactor Config class #25

rickard2 opened this issue Apr 6, 2013 · 3 comments
Assignees
@rickard2
Labels
code quality documentation
Milestone
2.3

Comments

@rickard2
Copy link
Owner

rickard2 commented Apr 6, 2013

Split the Config class into separate classes to reduce complexity and mess.

Maybe the configuration options could be logically grouped into data/style/other or something similar.

https://scrutinizer-ci.com/g/rickard2/utcw/inspections/e1998277-7477-43b6-ad71-6a2d45a124d7
@rickard2
Copy link
Owner Author

Code and tests complete. Needs code documentation and new user documentation for shortcode / theme integration

Should also be put through some user testing :P

@ghost ghost assigned rickard2 May 20, 2013
@rickard2
Copy link
Owner Author

Check scrutinizer if complexity/mess was reduced by refactoring

@rickard2
Copy link
Owner Author

There are now no problems with complexity or mess in the Config class, the only issue from scrutinizer is that IntegerType and MeasurementType shares a couple of lines which is flagged as copy/paste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickard2 rickard2

Labels
code quality documentation
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
1 participant
@rickard2