Repository navigation
Commit 37f6113
authored
Add --shader-report and --fail-on-unused-shaders option to impeller_golden_tests (flutter#193319)
Fixes flutter#193318
Adds a --shader-report option to impeller_golden_tests. When running
with this option, the test suite will spit out a report on which shaders
were prewarmed, but never used.
Adds a --fail-on-unused-shaders option to impeller_golden_tests. When
running with this option, the goldens will fail if there are any shaders
that are completely unused in the golden tests.
Everything is only run in debug builds inside of impeller_golden_tests,
so no production impact. --fail-on-unused-shaders is not hooked up to CI
yet.
Example output for --shader-report:
```
================================================================================
Impeller pipeline variant usage
================================================================================
2948 tests run, 55 skipped, 0 failed, filter '*'
Legend: SC = specialization constants, +flag = option enabled,
"drawn as" = how the same pipeline was actually drawn.
--------------------------------------------------------------------------------
Metal
276 variants: 137 warmed (0 drawn) | 0 created lazily, never drawn
Draws covered by warmed variants: 0 of 620,223 (0.0%)
WARMED BUT NEVER DRAWN (137) - candidates to stop warming
Likely cause: 111 of 137 were drawn, but only with other options:
111 depth Always -> GreaterEqual
48 blend SrcOver -> Src
45 format B10G10R10A10XR -> B8G8R8A8UNormInt
26 prim Triangle -> TriangleStrip
16 depth_stencil on -> off
16 msaa 4x -> 1x
4 prim TriangleStrip -> Triangle
2 blend SrcOver -> Dst
... 3 other changes
26 of 137 were never drawn with any options.
msaa=1x blend=SrcOver depth=Always stencil=Ignore prim=TriangleStrip format=B8G8R8A8UNormInt
Gaussian Pipeline SC=[1] drawn as: depth Always -> GreaterEqual (2,248 draws)
TextureDownsample Pipeline drawn as: depth Always -> GreaterEqual (866 draws)
TextureDownsampleBounded Pipeline drawn as: depth Always -> GreaterEqual (18 draws)
msaa=1x blend=SrcOver depth=Always stencil=Ignore prim=TriangleStrip format=B10G10R10A10XR
Gaussian Pipeline SC=[1] drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (2,248 draws)
TextureDownsample Pipeline drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (866 draws)
TextureDownsampleBounded Pipeline drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (18 draws)
msaa=4x blend=SrcOver depth=Always stencil=Ignore prim=Triangle format=B8G8R8A8UNormInt +depth_stencil
Circle Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (2,949 draws)
Clip Pipeline drawn as: blend SrcOver -> Dst, depth Always -> GreaterEqual, stencil Ignore -> StencilIncrementAll, prim Triangle -> TriangleStrip (390 draws)
ComplexRse Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (8 draws)
ConicalGradientSsboFill Pipeline SC=[0] never drawn with any options
ConicalGradientSsboFill Pipeline SC=[1] drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (8 draws)
ConicalGradientSsboFill Pipeline SC=[2] drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (4 draws)
ConicalGradientSsboFill Pipeline SC=[3] drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (41 draws)
FastGradient Pipeline drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, depth_write off -> on (8 draws)
GlyphAtlas Pipeline SC=[1] drawn as: depth Always -> GreaterEqual (690 draws)
LinearGradientSsboFill Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (86 draws)
RadialGradientSsboFill Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (96 draws)
ShadowVertices Pipeline drawn as: depth Always -> GreaterEqual (660 draws)
SolidFill Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (2,400 draws)
SweepGradientSsboFill Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (36 draws)
TextureFill Pipeline drawn as: depth Always -> GreaterEqual (16 draws)
TextureFillStrictSrc Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (60 draws)
TiledTextureFill Pipeline SC=[1] drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (418 draws)
UberSdf Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (295,723 draws)
VerticesUber1 Pipeline SC=[1] drawn as: depth Always -> GreaterEqual (8 draws)
VerticesUber2 Pipeline SC=[1] never drawn with any options
msaa=4x blend=SrcOver depth=Always stencil=Ignore prim=Triangle format=B10G10R10A10XR +depth_stencil
Circle Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (2,949 draws)
Clip Pipeline drawn as: blend SrcOver -> Dst, depth Always -> GreaterEqual, stencil Ignore -> StencilIncrementAll, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (390 draws)
ComplexRse Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (8 draws)
ConicalGradientSsboFill Pipeline SC=[0] never drawn with any options
ConicalGradientSsboFill Pipeline SC=[1] drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (8 draws)
ConicalGradientSsboFill Pipeline SC=[2] drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (4 draws)
ConicalGradientSsboFill Pipeline SC=[3] drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (41 draws)
FastGradient Pipeline drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt, depth_write off -> on (8 draws)
GlyphAtlas Pipeline SC=[1] drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (690 draws)
LinearGradientSsboFill Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (86 draws)
RadialGradientSsboFill Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (96 draws)
ShadowVertices Pipeline drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (660 draws)
SolidFill Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (2,400 draws)
SweepGradientSsboFill Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (36 draws)
TextureFill Pipeline drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (16 draws)
TextureFillStrictSrc Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (60 draws)
TiledTextureFill Pipeline SC=[1] drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip, format B10G10R10A10XR -> B8G8R8A8UNormInt (418 draws)
UberSdf Pipeline drawn as: depth Always -> GreaterEqual, prim Triangle -> TriangleStrip (2 draws)
VerticesUber1 Pipeline SC=[1] drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (8 draws)
VerticesUber2 Pipeline SC=[1] never drawn with any options
msaa=4x blend=SrcOver depth=Always stencil=Ignore prim=TriangleStrip format=B8G8R8A8UNormInt +depth_stencil
AdvancedBlend Pipeline SC=[0,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[1,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[2,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[3,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[4,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[5,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[6,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[7,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[8,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[9,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[10,1] drawn as: depth Always -> GreaterEqual (30 draws)
AdvancedBlend Pipeline SC=[11,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[12,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[13,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
AdvancedBlend Pipeline SC=[14,1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (2 draws)
BorderMaskBlur Pipeline never drawn with any options
ColorMatrixColorFilter Pipeline drawn as: depth Always -> GreaterEqual (68 draws)
FramebufferBlend Pipeline SC=[0,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (52 draws)
FramebufferBlend Pipeline SC=[1,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (44 draws)
FramebufferBlend Pipeline SC=[2,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (44 draws)
FramebufferBlend Pipeline SC=[3,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (52 draws)
FramebufferBlend Pipeline SC=[4,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (52 draws)
FramebufferBlend Pipeline SC=[5,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (44 draws)
FramebufferBlend Pipeline SC=[6,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (44 draws)
FramebufferBlend Pipeline SC=[7,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (44 draws)
FramebufferBlend Pipeline SC=[8,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (56 draws)
FramebufferBlend Pipeline SC=[9,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (76 draws)
FramebufferBlend Pipeline SC=[10,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (56 draws)
FramebufferBlend Pipeline SC=[11,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (44 draws)
FramebufferBlend Pipeline SC=[12,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (48 draws)
FramebufferBlend Pipeline SC=[13,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (44 draws)
FramebufferBlend Pipeline SC=[14,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual (44 draws)
LinearToSrgbFilter Pipeline drawn as: depth Always -> GreaterEqual (8 draws)
MorphologyFilter Pipeline SC=[1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, depth_stencil on -> off (48 draws)
PorterDuffBlend Pipeline SC=[1,0,0,0,0,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,0,0,0,0,1] drawn as: depth Always -> GreaterEqual (4 draws)
PorterDuffBlend Pipeline SC=[1,0,0,0,1,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,0,0,1,-1,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,0,0,1,0,-1] never drawn with any options
PorterDuffBlend Pipeline SC=[1,0,0,1,0,0] drawn as: depth Always -> GreaterEqual (20 draws)
PorterDuffBlend Pipeline SC=[1,0,1,0,0,0] drawn as: depth Always -> GreaterEqual, prim TriangleStrip -> Triangle (86 draws)
PorterDuffBlend Pipeline SC=[1,0,1,1,-1,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,1,-1,0,0,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,1,-1,0,1,0] drawn as: depth Always -> GreaterEqual, prim TriangleStrip -> Triangle (4 draws)
PorterDuffBlend Pipeline SC=[1,1,-1,1,-1,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,1,-1,1,0,0] drawn as: depth Always -> GreaterEqual (8 draws)
PorterDuffBlend Pipeline SC=[1,1,0,0,0,0] drawn as: depth Always -> GreaterEqual (8 draws)
PorterDuffBlend Pipeline SC=[1,1,0,1,-1,0] drawn as: depth Always -> GreaterEqual (6 draws)
PorterDuffBlend Pipeline SC=[1,1,0,1,0,0] drawn as: depth Always -> GreaterEqual, format B8G8R8A8UNormInt -> B10G10R10A10XR (4 draws)
RrectBlur Pipeline drawn as: depth Always -> GreaterEqual (454 draws)
RsuperellipseBlur Pipeline never drawn with any options
SrgbToLinearFilter Pipeline never drawn with any options
YuvToRgbFilter Pipeline never drawn with any options
msaa=4x blend=SrcOver depth=Always stencil=Ignore prim=TriangleStrip format=B10G10R10A10XR +depth_stencil
BorderMaskBlur Pipeline never drawn with any options
ColorMatrixColorFilter Pipeline drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (68 draws)
FramebufferBlend Pipeline SC=[0,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (52 draws)
FramebufferBlend Pipeline SC=[1,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (44 draws)
FramebufferBlend Pipeline SC=[2,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (44 draws)
FramebufferBlend Pipeline SC=[3,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (52 draws)
FramebufferBlend Pipeline SC=[4,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (52 draws)
FramebufferBlend Pipeline SC=[5,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (44 draws)
FramebufferBlend Pipeline SC=[6,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (44 draws)
FramebufferBlend Pipeline SC=[7,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (44 draws)
FramebufferBlend Pipeline SC=[8,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (56 draws)
FramebufferBlend Pipeline SC=[9,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (76 draws)
FramebufferBlend Pipeline SC=[10,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (56 draws)
FramebufferBlend Pipeline SC=[11,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (44 draws)
FramebufferBlend Pipeline SC=[12,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (48 draws)
FramebufferBlend Pipeline SC=[13,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (44 draws)
FramebufferBlend Pipeline SC=[14,1] drawn as: blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (44 draws)
LinearToSrgbFilter Pipeline drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (8 draws)
MorphologyFilter Pipeline SC=[1] drawn as: msaa 4x -> 1x, blend SrcOver -> Src, depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt, depth_stencil on -> off (48 draws)
PorterDuffBlend Pipeline SC=[1,0,0,0,0,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,0,0,0,0,1] drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (4 draws)
PorterDuffBlend Pipeline SC=[1,0,0,0,1,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,0,0,1,-1,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,0,0,1,0,-1] never drawn with any options
PorterDuffBlend Pipeline SC=[1,0,0,1,0,0] drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (20 draws)
PorterDuffBlend Pipeline SC=[1,0,1,0,0,0] drawn as: depth Always -> GreaterEqual, prim TriangleStrip -> Triangle, format B10G10R10A10XR -> B8G8R8A8UNormInt (86 draws)
PorterDuffBlend Pipeline SC=[1,0,1,1,-1,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,1,-1,0,0,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,1,-1,0,1,0] drawn as: depth Always -> GreaterEqual, prim TriangleStrip -> Triangle, format B10G10R10A10XR -> B8G8R8A8UNormInt (4 draws)
PorterDuffBlend Pipeline SC=[1,1,-1,1,-1,0] never drawn with any options
PorterDuffBlend Pipeline SC=[1,1,-1,1,0,0] drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (8 draws)
PorterDuffBlend Pipeline SC=[1,1,0,0,0,0] drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (8 draws)
PorterDuffBlend Pipeline SC=[1,1,0,1,-1,0] drawn as: depth Always -> GreaterEqual, format B10G10R10A10XR -> B8G8R8A8UNormInt (6 draws)
PorterDuffBlend Pipeline SC=[1,1,0,1,0,0] drawn as: depth Always -> GreaterEqual (4 draws)
RrectBlur Pipeline drawn as: depth Always -> GreaterEqual (4 draws)
RsuperellipseBlur Pipeline never drawn with any options
SrgbToLinearFilter Pipeline never drawn with any options
YuvToRgbFilter Pipeline never drawn with any options
```
Example output for --fail-on-unused-shaders:
```
================================================================================
Unused Impeller shaders
================================================================================
13 shaders were created by a ContentContext but never drawn with, with
any options, on any backend:
BorderMaskBlur Pipeline [Metal]
ConicalGradientSsboFill Pipeline spec=[0] [Metal]
PorterDuffBlend Pipeline spec=[1,0,0,0,0,0] [Metal]
PorterDuffBlend Pipeline spec=[1,0,0,0,1,0] [Metal]
PorterDuffBlend Pipeline spec=[1,0,0,1,-1,0] [Metal]
PorterDuffBlend Pipeline spec=[1,0,0,1,0,-1] [Metal]
PorterDuffBlend Pipeline spec=[1,0,1,1,-1,0] [Metal]
PorterDuffBlend Pipeline spec=[1,1,-1,0,0,0] [Metal]
PorterDuffBlend Pipeline spec=[1,1,-1,1,-1,0] [Metal]
RsuperellipseBlur Pipeline [Metal]
SrgbToLinearFilter Pipeline [Metal]
VerticesUber2 Pipeline spec=[1] [Metal]
YuvToRgbFilter Pipeline [Metal]
Add a golden test that draws with each of them, or stop creating them.
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].1 parent ea4ba77 commit 37f6113
13 files changed
Lines changed: 2264 additions & 2 deletions
File tree
- engine/src/flutter/impeller
- entity
- contents
- golden_tests
- playground
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| 93 | + | |
93 | 94 | | |
94 | 95 | | |
95 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
| 179 | + | |
| 180 | + | |
179 | 181 | | |
180 | 182 | | |
181 | 183 | | |
| |||
292 | 294 | | |
293 | 295 | | |
294 | 296 | | |
| 297 | + | |
295 | 298 | | |
296 | 299 | | |
297 | 300 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| 46 | + | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
| |||
171 | 173 | | |
172 | 174 | | |
173 | 175 | | |
| 176 | + | |
| 177 | + | |
174 | 178 | | |
175 | 179 | | |
176 | 180 | | |
| |||
573 | 577 | | |
574 | 578 | | |
575 | 579 | | |
| 580 | + | |
| 581 | + | |
576 | 582 | | |
577 | 583 | | |
578 | 584 | | |
| |||
883 | 889 | | |
884 | 890 | | |
885 | 891 | | |
886 | | - | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
887 | 895 | | |
888 | 896 | | |
889 | 897 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
0 commit comments