Repository navigation
Commit 132e1c6
[Skia][DisplayList] Map local bounds through the local matrix in DlLocalMatrixImageFilter (flutter#193963)
Fixes flutter#170535
`DlLocalMatrixImageFilter::map_local_bounds` ignored `matrix_`, so on
Skia raster cached `Transform` with `filterQuality` got wrong bounds,
and `DisplayListBuilder` skipped drawing it when it was only partly
visible. The bounds are now mapped through `matrix_`, as
`map_device_bounds` already does.
This line comes from flutter-team-archive/engine#34878, where the review asked for a
comparison with Skia
([comment](flutter-team-archive/engine#34878 (comment))).
This PR adds it for `map_local_bounds` in `LocalImageFilterBounds`, plus
a `LocalMatrixBounds` test. Both fail without the fix
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making.
- [x] All existing and new tests are passing.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[CLA]: https://cla.developers.google.com/
---------
Co-authored-by: gaaclarke <[email protected]>1 parent b0a88aa commit 132e1c6
2 files changed
Lines changed: 43 additions & 1 deletion
File tree
- engine/src/flutter/display_list/effects
- image_filters
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
751 | 751 | | |
752 | 752 | | |
753 | 753 | | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
754 | 772 | | |
755 | 773 | | |
756 | 774 | | |
| |||
865 | 883 | | |
866 | 884 | | |
867 | 885 | | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
868 | 899 | | |
869 | 900 | | |
870 | 901 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
32 | 43 | | |
33 | 44 | | |
34 | 45 | | |
| |||
0 commit comments