You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 39592d1
Browse filesBrowse the repository at this point in the historyBrowse files
Rich Kadel
committed
Fix building Dart Fuchsia components and packages
The previous PR did not build the Fuchsia packages correctly:
> GN build rules for tests using Fuchsia SDK Dart libraries
and bindings flutter-team-archive#27996
The new changes bring in more of the Fuchsia GN-SDK build rules. Some
changes to these rules were required because the fuchsia.git-derived
flutter/dart build rules depend on a different implementation of
similar-sounding rules (fuchsia.git <> Fuchsia GN SDK, regarding build
rule implementations).
I renamed flutter/tools/fuchsia/sdk to flutter/tools/fuchsia/gn-sdk to
be more clear that GN SDK was the original source.
Also, I realized there were still some references to python3.8 and
python3_action. Now that flutter is building with python3 by default,
that action is no longer needed, so I've removed it.
Fixes: flutter/flutter#87999 (because the original fix had
deficiencies)
Tested in Fuchsia and confirmed the dart package/component launches
and runs.
0 commit comments