Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable noprov in wikidata revision history #270

Merged
merged 4 commits into from
Mar 1, 2025
Merged

Conversation

ross-spencer
Copy link
Collaborator

@ross-spencer ross-spencer commented Jan 18, 2025

Should probably sit in dev branch for a while.

  • Updates wikiprov.
  • Adds -noprov flag (revision history is still default, but friendlier to Wikidata's Wikibase). NB. input on names appreciated.
  • Simplifies logging thanks to b27db87.
  • Adds binaries to .gitignore.

Relies on ross-spencer/wikiprov#8
Resolves: #183

how to test

As-is:

./roy harvest -wikidata

Without provenance:

./roy harvest -wikidata -noprov

Building:

./roy build -wikidata -nopronom

Testing inspect:

./roy inspect -nopronom -wikidata Q42591

Additional logging context introduced in b27db87 means we can remove
extraneous context.
@ross-spencer ross-spencer changed the base branch from main to develop January 18, 2025 13:15
This should help devs reviewing diffs locally.
This should not be a barrier to testing. Users can optionally add
-noprov to their `roy harvest -wikidata -noprov` command.
@ross-spencer
Copy link
Collaborator Author

@richardlehane I think you may have a lot on your plate with the standard release? Maybe when you have a second afterwards, could you mint a beta for this PR? I've updated the Wikiprov package to be more forgiving and should resolve #183.

@richardlehane
Copy link
Owner

@richardlehane I think you may have a lot on your plate with the standard release? Maybe when you have a second afterwards, could you mint a beta for this PR? I've updated the Wikiprov package to be more forgiving and should resolve #183.

Hi @ross-spencer I've minted a release candidate for this branch. The PR looks fine to me - do you want me to merge it to develop branch yet? I've been getting the develop branch ready for a new release but will probably wait until next pronom comes out before finalising it (I want to skip PRONOM v119 altogether as those updates seem to have broken more signatures than they have fixed)

@ross-spencer
Copy link
Collaborator Author

thanks @richardlehane I appreciate it! wrt to merging, I just wanted to be cautious to make sure it worked elsewhere, so maybe Tyler has an opportunity to try it, or I'll give it a go from the rc on another machine of mine and see. Then I'll merge the code upstream at wikiprov and then update the go.mod here. Maybe revisit this time next week?

@ross-spencer ross-spencer changed the title WIP: no wikidata revision history Enable noprov in wikidata revision history Jan 29, 2025
@ross-spencer ross-spencer marked this pull request as ready for review January 29, 2025 07:55
@ross-spencer
Copy link
Collaborator Author

hi @richardlehane given Ethan's successful test this is looking good. I also tested on two other distros:

No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.1 LTS
Release:        22.04
Codename:       jammy
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"

And it's looking good.

Have added v1.0.0 of wikiprov to the dependencies and committed those here and converted the issue from draft.

@ross-spencer
Copy link
Collaborator Author

btw:

I want to skip PRONOM v119 altogether as those updates seem to have broken more signatures than they have fixed

Anything that I can help with at all? (is it the sig file?)

@richardlehane
Copy link
Owner

btw:

I want to skip PRONOM v119 altogether as those updates seem to have broken more signatures than they have fixed

Anything that I can help with at all? (is it the sig file?)

Thx Ross it's just a PRONOM bug that I think is already fixed and should be available in the next release. One of the new quark signatures broke identification for most other quark variants: digital-preservation/PRONOM_Research#54

@richardlehane richardlehane merged commit 99440ba into develop Mar 1, 2025
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants