-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable noprov in wikidata revision history #270
Conversation
Additional logging context introduced in b27db87 means we can remove extraneous context.
edcbcd2
to
7c15431
Compare
This should help devs reviewing diffs locally.
This should not be a barrier to testing. Users can optionally add -noprov to their `roy harvest -wikidata -noprov` command.
7c15431
to
9fe25df
Compare
@richardlehane I think you may have a lot on your plate with the standard release? Maybe when you have a second afterwards, could you mint a beta for this PR? I've updated the Wikiprov package to be more forgiving and should resolve #183. |
Hi @ross-spencer I've minted a release candidate for this branch. The PR looks fine to me - do you want me to merge it to develop branch yet? I've been getting the develop branch ready for a new release but will probably wait until next pronom comes out before finalising it (I want to skip PRONOM v119 altogether as those updates seem to have broken more signatures than they have fixed) |
thanks @richardlehane I appreciate it! wrt to merging, I just wanted to be cautious to make sure it worked elsewhere, so maybe Tyler has an opportunity to try it, or I'll give it a go from the rc on another machine of mine and see. Then I'll merge the code upstream at wikiprov and then update the go.mod here. Maybe revisit this time next week? |
9fe25df
to
781c111
Compare
hi @richardlehane given Ethan's successful test this is looking good. I also tested on two other distros:
And it's looking good. Have added v1.0.0 of wikiprov to the dependencies and committed those here and converted the issue from draft. |
btw:
Anything that I can help with at all? (is it the sig file?) |
Thx Ross it's just a PRONOM bug that I think is already fixed and should be available in the next release. One of the new quark signatures broke identification for most other quark variants: digital-preservation/PRONOM_Research#54 |
Should probably sit in dev branch for a while.
-noprov
flag (revision history is still default, but friendlier to Wikidata's Wikibase). NB. input on names appreciated.Relies on ross-spencer/wikiprov#8
Resolves: #183
how to test
As-is:
Without provenance:
Building:
Testing inspect: