Skip to content

Commit 88fa7dc

Browse files
committed
Remove mediaTypeGraphQLNodeIDPreview from custom accept headers for DownloadReleaseAsset()
Fixes google#870
1 parent 8eefe6b commit 88fa7dc

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎github/repos_releases.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ func (s *RepositoriesService) DownloadReleaseAsset(ctx context.Context, owner, r
253253
}
254254

255255
// TODO: remove custom Accept header when APIs fully launch.
256-
acceptHeaders := []string{defaultMediaType, mediaTypeGraphQLNodeIDPreview}
256+
acceptHeaders := []string{defaultMediaType}
257257
req.Header.Set("Accept", strings.Join(acceptHeaders, ", "))
258258

259259
s.client.clientMu.Lock()

‎github/repos_releases_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ func TestRepositoriesService_DownloadReleaseAsset_Stream(t *testing.T) {
220220
client, mux, _, teardown := setup()
221221
defer teardown()
222222

223-
acceptHeaders := []string{defaultMediaType, mediaTypeGraphQLNodeIDPreview}
223+
acceptHeaders := []string{defaultMediaType}
224224
mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) {
225225
testMethod(t, r, "GET")
226226
testHeader(t, r, "Accept", strings.Join(acceptHeaders, ", "))
@@ -247,7 +247,7 @@ func TestRepositoriesService_DownloadReleaseAsset_Redirect(t *testing.T) {
247247
client, mux, _, teardown := setup()
248248
defer teardown()
249249

250-
acceptHeaders := []string{defaultMediaType, mediaTypeGraphQLNodeIDPreview}
250+
acceptHeaders := []string{defaultMediaType}
251251
mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) {
252252
testMethod(t, r, "GET")
253253
testHeader(t, r, "Accept", strings.Join(acceptHeaders, ", "))
@@ -268,7 +268,7 @@ func TestRepositoriesService_DownloadReleaseAsset_APIError(t *testing.T) {
268268
client, mux, _, teardown := setup()
269269
defer teardown()
270270

271-
acceptHeaders := []string{defaultMediaType, mediaTypeGraphQLNodeIDPreview}
271+
acceptHeaders := []string{defaultMediaType}
272272
mux.HandleFunc("/repos/o/r/releases/assets/1", func(w http.ResponseWriter, r *http.Request) {
273273
testMethod(t, r, "GET")
274274
testHeader(t, r, "Accept", strings.Join(acceptHeaders, ", "))

0 commit comments

Comments
 (0)