Skip to content

Add SigV4 credential signing and JSON-RPC fields on NetworkEndpoint #37

Closed

Description

@rhuss

Proto Gap: NetworkEndpoint Extensions

New fields on NetworkEndpoint for AWS SigV4 credential signing and JSON-RPC body size limits.

New proto fields on NetworkEndpoint (sandbox.proto)

Field Type Line Purpose
credential_signing string 166 Enable SigV4 signing (e.g., "aws-sigv4")
signing_service string 169 AWS service name for signing
signing_region string 172 AWS region for signing
json_rpc_max_body_bytes uint32 175 Max JSON-RPC request body size

Implementation scope

  • Add fields to NetworkEndpoint domain type in types/policy.go
  • Update network endpoint converter
  • Add to coverage test handled set
  • Unit tests

Target drop

Drop D (Policy + Service + TCP + SSH)

References

  • sandbox.proto lines 166-175

Activity

  1. added
    proto-gapProto API surface not yet covered by SDK
    drop-dTarget: Drop D (Policy + Network)
    on Jul 29, 2026
  2. rhuss commented on Jul 29, 2026

    @rhuss
    OwnerAuthor

    Implementation Hints

    Implement directly with plan mode (/plan in Claude Code). Trivial field additions.

    Approach

    1. Add 4 fields to PolicyNetworkEndpoint in types/policy.go:

      • CredentialSigning string
      • SigningService string
      • SigningRegion string
      • JsonRpcMaxBodyBytes uint32
    2. Update the network endpoint converter to map these fields in both directions

    3. Add to coverage test handled sets

    Pattern to follow

    See existing fields on PolicyNetworkEndpoint (Host, Port, Protocol, etc.) in types/policy.go.

    Verification

    make lint && make build && make test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    drop-dTarget: Drop D (Policy + Network)proto-gapProto API surface not yet covered by SDK

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions