Blocks in the freelist have already been freed

rhettinger · rhettinger · commit 79f20e359ee4 · 2021-05-04T15:37:26.000-07:00
diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
@@ -1306,8 +1306,6 @@ deque_ass_item(dequeobject *deque, Py_ssize_t i, PyObject *v)
 static void
 deque_dealloc(dequeobject *deque)
 {
-    Py_ssize_t i;
-
     PyObject_GC_UnTrack(deque);
     if (deque->weakreflist != NULL)
         PyObject_ClearWeakRefs((PyObject *) deque);
@@ -1318,9 +1316,6 @@ deque_dealloc(dequeobject *deque)
     }
     deque->leftblock = NULL;
     deque->rightblock = NULL;
-    for (i=0 ; i < deque->numfreeblocks ; i++) {
-        free(deque->freeblocks[i]);
-    }
     Py_TYPE(deque)->tp_free(deque);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1306,8 +1306,6 @@ deque_ass_item(dequeobject deque, Py_ssize_t i, PyObject v)`
`1306`	`1306`	`static void`
`1307`	`1307`	`deque_dealloc(dequeobject *deque)`
`1308`	`1308`	`{`
`1309`		`- Py_ssize_t i;`
`1310`		`-`
`1311`	`1309`	`PyObject_GC_UnTrack(deque);`
`1312`	`1310`	`if (deque->weakreflist != NULL)`
`1313`	`1311`	`PyObject_ClearWeakRefs((PyObject *) deque);`
`@@ -1318,9 +1316,6 @@ deque_dealloc(dequeobject *deque)`
`1318`	`1316`	`}`
`1319`	`1317`	`deque->leftblock = NULL;`
`1320`	`1318`	`deque->rightblock = NULL;`
`1321`		`- for (i=0 ; i < deque->numfreeblocks ; i++) {`
`1322`		`- free(deque->freeblocks[i]);`
`1323`		`- }`
`1324`	`1319`	`Py_TYPE(deque)->tp_free(deque);`
`1325`	`1320`	`}`
`1326`	`1321`