Support terminals with light background#23
Merged
rgwood merged 1 commit intorgwood:masterfrom Sep 14, 2024
Merged
Conversation
In terminals with a light background, white text is very hard or even impossible to read. This revision changes white text to "reset", which is a pseudo-color that resets to the default colors. An alternative approach could be to use https://github.com/Canop/terminal-light to check the terminal background luma and determine a suitable default text color from that, but since we're not styling the terminal background the reset approach seemed more straightforward.
Owner
|
Thanks for the contribution! This sounds good, I’ll review the PR when I have time this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In terminals with a light background, white text is very hard or even impossible to read.
This revision changes white text to "reset", which is a pseudo-color that resets to the default colors.
An alternative approach could be to use https://github.com/Canop/terminal-light to check the terminal background luma and determine a suitable default text color from that,
but since we're not styling the terminal background the reset approach seemed more straightforward.